Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show a folder named '&' after creating a folder with the name '&' #3377

Closed
v-xianya opened this issue Aug 11, 2020 · 6 comments
Closed
Assignees
Labels
🪲 regression Issue was working in a previous version ⚙️ files Related to file storage 🧪 testing Found through regular testing
Milestone

Comments

@v-xianya
Copy link
Member

Storage Explorer Version: 1.15.0-dev
Build: 20200811.2
Branch: master
Platform/OS: Windows 10/ CentOS 7.6.1810 (Core) / MacOS Catalina
Architecture: ia32/x64
Regression From: Previous release (1.12.0)

Steps to reproduce:

  1. Expand one storage account -> File Shares.
  2. Create a file share -> Click 'New Folder' -> Input '&' as the new folder name -> Click 'OK'.
  3. Check the result.

Expect Experience:
Show a folder named '&'.
image

Actual Experience:
Show a folder namedimage.

image

More Info:

  1. Show '&' on the path.
  2. Show blank under the 'Recent locations' dropdown list.
    image
  3. This issue doesn't reproduce for ADLS Gen2 blob containers.
@v-xianya v-xianya added 🧪 testing Found through regular testing ⚙️ files Related to file storage 🪲 regression Issue was working in a previous version labels Aug 11, 2020
@MRayermannMSFT MRayermannMSFT added this to the 1.15.0 milestone Aug 17, 2020
@craxal
Copy link
Contributor

craxal commented Aug 18, 2020

The menu problem looks like an Electron bug/missing feature. The ampersand is stripped out and interpreted as a keyboard accelerator. I've opened electron/electron#25028.

The "&" is the result of double-encoding done when displaying the folder name in the data table. The data itself is correct (verified in the portal), but I'm not sure why this has changed (since I don't see any relevant changes in that part of the code.

@craxal craxal modified the milestones: 1.15.0, 1.16.0 Aug 24, 2020
@craxal craxal modified the milestones: 1.16.0, 1.17.0 Oct 20, 2020
@MRayermannMSFT MRayermannMSFT modified the milestones: 1.17.0, 1.18.0 Nov 6, 2020
@v-limu
Copy link

v-limu commented Nov 27, 2020

Verified on build 20201126.1. This issue doesn't reproduce. So we close it.

@v-limu v-limu closed this as completed Nov 27, 2020
@craxal
Copy link
Contributor

craxal commented Dec 1, 2020

@v-limu The Electron bug is still open. Is the Recent Locations menu part still an issue? If so, please reopen this bug so we can track.

@v-limu
Copy link

v-limu commented Dec 2, 2020

Hi @craxal Got it. Thanks for your update. This issue is re-opened now.

@v-limu v-limu reopened this Dec 2, 2020
@craxal
Copy link
Contributor

craxal commented Jan 4, 2021

@v-limu Can you help create a separate issue for the menu item? The & issue should be fixed, but the menu item is a separate issue.

@v-limu
Copy link

v-limu commented Jan 5, 2021

Hi @craxal OK. The 'Recent locations' menu part is still reproduces. We logged a new bug for the menu item. 3955

@v-limu v-limu closed this as completed Jan 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪲 regression Issue was working in a previous version ⚙️ files Related to file storage 🧪 testing Found through regular testing
Projects
None yet
Development

No branches or pull requests

4 participants