Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move CMakeList.txt into src/Linux and updated ReadMe file #132

Merged
merged 5 commits into from
Mar 16, 2021

Conversation

wewang3
Copy link
Contributor

@wewang3 wewang3 commented Mar 12, 2021

Move CMakeList.txt file into src/Linux
Updated the ReadMe file
Updated nuget package version file

Copy link
Collaborator

@szutshi-msft szutshi-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like just comment changes, so lgtm.

@@ -1,7 +1,7 @@
az-dcap-client (1.7) stable; urgency=medium
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make a new version instead of copying over previous if you are going to make a new release

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We did not release 1.7.0 before. So I changed the description and make a release of 1.7.0 version

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for clarifying :) I'll approve

@@ -7,7 +7,7 @@
<authors>Microsoft</authors>
<owners>Microsoft</owners>
<requireLicenseAcceptance>false</requireLicenseAcceptance>
<releaseNotes>Use the Cache-Control header to determine how long collateral should be cached for. Cleanup of error handling logs in Windows</releaseNotes>
<releaseNotes>Enable v3 for icx and coffelake and Use the Cache-Control header to determine how long collateral should be cached for. Cleanup of error handling logs in Windows</releaseNotes>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would just fill this in with what has changed. History will be available on the previous versions

@wewang3 wewang3 merged commit 2b5530e into master Mar 16, 2021
@wewang3 wewang3 deleted the dev_wewang3_gtest2 branch April 12, 2021 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants