Add a heartbeat-specific version property to the metrics sent as hear… #782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SergeyKanzhelev
approved these changes
Apr 19, 2018
|
Please also register this new prefix here: https://github.com/Microsoft/ApplicationInsights-Home/blob/master/EndpointSpecs/SDK-VERSIONS.md |
cijothomas
approved these changes
Apr 19, 2018
| /// <summary> | ||
| /// Value for property indicating 'app insights version' related specifically to heartbeats. | ||
| /// </summary> | ||
| private static string sdkVersionPropertyValue = SdkVersionUtils.GetSdkVersion("hbeat:"); |
There was a problem hiding this comment.
just 'hb' is sufficient to save space.
There was a problem hiding this comment.
Agreed. Will make the change.
There was a problem hiding this comment.
Done. Please accept PR Microsoft/ApplicationInsights-Home#214 along with this one.
2 tasks
|
@cijothomas or @SergeyKanzhelev could you please merge Microsoft/ApplicationInsights-Home#214 to coincide with this change? Thanks. |
TimothyMothra
pushed a commit
that referenced
this pull request
Oct 25, 2019
dev to master for 2.6.0-beta1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a heartbeat-specific version string to the properties of the metrics sent as heartbeats.