Skip to content

Restore OTEL_SDK_DISABLED in AzureMonitorExporterOptions callbacks #3157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
harsimar merged 3 commits into from
Apr 1, 2026
Merged

Restore OTEL_SDK_DISABLED in AzureMonitorExporterOptions callbacks #3157

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d917ec3
Restore OTEL_SDK_DISABLED in AzureMonitorExporterOptions callbacks
rajkumar-rangaraj Mar 31, 2026
a1200f3
Fix DisableTelemetry not disabling OTel LoggerProvider export
rajkumar-rangaraj Mar 31, 2026
eb5a75b
Update CHANGELOG entry for DisableTelemetry fix
rajkumar-rangaraj Mar 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .../src/Microsoft.ApplicationInsights.AspNetCore/Extensions/ApplicationInsightsExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,6 +205,12 @@ internal static IOpenTelemetryBuilder UseApplicationInsightsTelemetry(this IOpen
{
var serviceOptions = aiOptions.Value;

// Set OTEL_SDK_DISABLED in configuration if DisableTelemetry is true
if (telemetryConfig.DisableTelemetry)
{
config["OTEL_SDK_DISABLED"] = "true";
}

Comment thread
rajkumar-rangaraj marked this conversation as resolved.
if (!string.IsNullOrEmpty(telemetryConfig.StorageDirectory))
{
exporterOptions.StorageDirectory = telemetryConfig.StorageDirectory;
Expand Down
6 changes: 6 additions & 0 deletions NETCORE/src/Microsoft.ApplicationInsights.WorkerService/ApplicationInsightsExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,6 +200,12 @@ internal static IOpenTelemetryBuilder UseApplicationInsightsTelemetry(this IOpen
{
var serviceOptions = aiOptions.Value;

// Set OTEL_SDK_DISABLED in configuration if DisableTelemetry is true
if (telemetryConfig.DisableTelemetry)
{
config["OTEL_SDK_DISABLED"] = "true";
}

Comment on lines +203 to +208

Copilot AI Mar 31, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This OTEL_SDK_DISABLED assignment is redundant: AddTelemetryConfigAndClient already sets IConfiguration["OTEL_SDK_DISABLED"] = "true" during TelemetryConfiguration resolution when DisableTelemetry is true (NETCORE/src/Shared/Extensions/ApplicationInsightsExtensions.cs:125-134). Since telemetryConfig is resolved before this callback executes, this block doesn’t change behavior and adds another place to maintain this logic; consider removing it and keeping the setting centralized in the shared TelemetryConfiguration factory.

Suggested change
// Set OTEL_SDK_DISABLED in configuration if DisableTelemetry is true
if (telemetryConfig.DisableTelemetry)
{
config["OTEL_SDK_DISABLED"] = "true";
}

Copilot uses AI. Check for mistakes.

@rajkumar-rangaraj rajkumar-rangaraj Apr 1, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Intentionally keeping this as defense-in-depth. The TelemetryConfiguration factory covers MeterProvider, but TracerProvider may resolve through a different path. Setting the same value twice in IConfiguration is harmless and this was the original behavior on main before #3156.

if (!string.IsNullOrEmpty(telemetryConfig.StorageDirectory))
{
exporterOptions.StorageDirectory = telemetryConfig.StorageDirectory;
Expand Down
Loading