Skip to content

Conversation

@rajkumar-rangaraj
Copy link
Member

@rajkumar-rangaraj rajkumar-rangaraj commented Jan 22, 2026

  • Centralized package management
  • Updates OpenTelemetry packages
  • Fixed test issue

Copilot AI review requested due to automatic review settings January 22, 2026 17:22
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request implements centralized package management for the ApplicationInsights-dotnet solution by introducing a Directory.Packages.props file and updating all project files to remove explicit version attributes. The change consolidates package version management in a single location, making it easier to maintain consistency across the codebase.

Changes:

  • Added Directory.Packages.props file with centralized version definitions for all NuGet packages
  • Updated Directory.Build.props to enable centralized package management
  • Removed Version attributes from PackageReference elements across all project files
  • Updated several package versions (OpenTelemetry 1.14.0→1.15.0, test frameworks, Microsoft.Extensions packages, and others)
  • Added SamplingRatio configuration in test files to ensure full telemetry capture

Reviewed changes

Copilot reviewed 22 out of 22 changed files in this pull request and generated 12 comments.

Show a summary per file
File Description
Directory.Packages.props New file defining centralized package versions for all dependencies
Directory.Build.props Enables centralized package management with ManagePackageVersionsCentrally property
examples/*/csproj Removed explicit version attributes, now managed centrally
WEB/Src/Web/*/csproj Removed explicit version attributes for OpenTelemetry and Microsoft packages
NETCORE/src/*/csproj Removed explicit version attributes for OpenTelemetry instrumentation packages
NETCORE/test/*/csproj Removed explicit version attributes, added VersionOverride for framework-specific versions
LOGGING/*/csproj Removed explicit NLog version attributes
BASE/src/Microsoft.ApplicationInsights/Microsoft.ApplicationInsights.csproj Removed version attributes for Azure Monitor and EventRegister packages
BASE/Test/**/TelemetryClient*.cs Added SamplingRatio=1.0f configuration in test constructors
BASE/Test/**/Microsoft.ApplicationInsights.Tests.csproj Removed explicit version attributes for test dependencies
.props/Product.props Removed deprecated FxCopAnalyzers package, removed version attributes for analyzers

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +126 to +128
<PackageVersion Include="Microsoft.AspNet.Mvc" Version="5.3.0" />
<PackageVersion Include="Microsoft.AspNet.TelemetryCorrelation" Version="1.0.8" />
<PackageVersion Include="Microsoft.AspNet.WebApi" Version="5.3.0" />
Copy link

Copilot AI Jan 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The versions for Microsoft.AspNet.Mvc and Microsoft.AspNet.WebApi have been changed from 5.2.4 to 5.3.0. This represents a minor version update that could introduce new behavior or breaking changes for existing code. Please verify that this version upgrade has been tested and doesn't introduce compatibility issues with the existing codebase.

Copilot uses AI. Check for mistakes.
@rajkumar-rangaraj rajkumar-rangaraj merged commit ec9e4b4 into main Jan 22, 2026
22 checks passed
@rajkumar-rangaraj rajkumar-rangaraj deleted the rajrang/updatePackage branch January 22, 2026 19:31
This was referenced Feb 1, 2026
This was referenced Feb 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants