-
Notifications
You must be signed in to change notification settings - Fork 295
Centralized package management / Update packages #3080
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request implements centralized package management for the ApplicationInsights-dotnet solution by introducing a Directory.Packages.props file and updating all project files to remove explicit version attributes. The change consolidates package version management in a single location, making it easier to maintain consistency across the codebase.
Changes:
- Added Directory.Packages.props file with centralized version definitions for all NuGet packages
- Updated Directory.Build.props to enable centralized package management
- Removed Version attributes from PackageReference elements across all project files
- Updated several package versions (OpenTelemetry 1.14.0→1.15.0, test frameworks, Microsoft.Extensions packages, and others)
- Added SamplingRatio configuration in test files to ensure full telemetry capture
Reviewed changes
Copilot reviewed 22 out of 22 changed files in this pull request and generated 12 comments.
Show a summary per file
| File | Description |
|---|---|
| Directory.Packages.props | New file defining centralized package versions for all dependencies |
| Directory.Build.props | Enables centralized package management with ManagePackageVersionsCentrally property |
| examples/*/csproj | Removed explicit version attributes, now managed centrally |
| WEB/Src/Web/*/csproj | Removed explicit version attributes for OpenTelemetry and Microsoft packages |
| NETCORE/src/*/csproj | Removed explicit version attributes for OpenTelemetry instrumentation packages |
| NETCORE/test/*/csproj | Removed explicit version attributes, added VersionOverride for framework-specific versions |
| LOGGING/*/csproj | Removed explicit NLog version attributes |
| BASE/src/Microsoft.ApplicationInsights/Microsoft.ApplicationInsights.csproj | Removed version attributes for Azure Monitor and EventRegister packages |
| BASE/Test/**/TelemetryClient*.cs | Added SamplingRatio=1.0f configuration in test constructors |
| BASE/Test/**/Microsoft.ApplicationInsights.Tests.csproj | Removed explicit version attributes for test dependencies |
| .props/Product.props | Removed deprecated FxCopAnalyzers package, removed version attributes for analyzers |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| <PackageVersion Include="Microsoft.AspNet.Mvc" Version="5.3.0" /> | ||
| <PackageVersion Include="Microsoft.AspNet.TelemetryCorrelation" Version="1.0.8" /> | ||
| <PackageVersion Include="Microsoft.AspNet.WebApi" Version="5.3.0" /> |
Copilot
AI
Jan 22, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The versions for Microsoft.AspNet.Mvc and Microsoft.AspNet.WebApi have been changed from 5.2.4 to 5.3.0. This represents a minor version update that could introduce new behavior or breaking changes for existing code. Please verify that this version upgrade has been tested and doesn't introduce compatibility issues with the existing codebase.
Uh oh!
There was an error while loading. Please reload this page.