-
Notifications
You must be signed in to change notification settings - Fork 295
Updated JavaScript to version 10 in Microsoft.ApplicationInsights.AspNetCore #3078
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request updates the Application Insights JavaScript SDK from version 5 (ai.2.min.js) to version 10 (ai.3.gbl.min.js) and changes the configuration approach from instrumentationKey to connectionString.
Changes:
- Updated JavaScript snippet in Resources.resx from SDK v5 (ai.2.min.js) to v10 (ai.3.gbl.min.js)
- Changed configuration format from
instrumentationKey: "INSTRUMENTATION_KEY"toconnectionString: "YOUR_CONNECTION_STRING" - Updated C# string replacement logic in JavaScriptSnippet.cs to use connectionString placeholder
- Added changelog entry documenting the JavaScript version upgrade
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| NETCORE/src/Microsoft.ApplicationInsights.AspNetCore/Resources.resx | Updates JavaScript snippet from SDK v5 to v10 with new configuration format using connectionString |
| NETCORE/src/Microsoft.ApplicationInsights.AspNetCore/JavaScriptSnippet.cs | Updates string replacement to use connectionString placeholder instead of instrumentationKey |
| CHANGELOG.md | Documents the JavaScript SDK version upgrade |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
NETCORE/src/Microsoft.ApplicationInsights.AspNetCore/JavaScriptSnippet.cs
Show resolved
Hide resolved
harsimar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A note for later - is there a way to automate the updating of the snippet
No description provided.