Skip to content

Conversation

@rajkumar-rangaraj
Copy link
Member

No description provided.

Copilot AI review requested due to automatic review settings January 21, 2026 00:42
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request updates the Application Insights JavaScript SDK from version 5 (ai.2.min.js) to version 10 (ai.3.gbl.min.js) and changes the configuration approach from instrumentationKey to connectionString.

Changes:

  • Updated JavaScript snippet in Resources.resx from SDK v5 (ai.2.min.js) to v10 (ai.3.gbl.min.js)
  • Changed configuration format from instrumentationKey: "INSTRUMENTATION_KEY" to connectionString: "YOUR_CONNECTION_STRING"
  • Updated C# string replacement logic in JavaScriptSnippet.cs to use connectionString placeholder
  • Added changelog entry documenting the JavaScript version upgrade

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

File Description
NETCORE/src/Microsoft.ApplicationInsights.AspNetCore/Resources.resx Updates JavaScript snippet from SDK v5 to v10 with new configuration format using connectionString
NETCORE/src/Microsoft.ApplicationInsights.AspNetCore/JavaScriptSnippet.cs Updates string replacement to use connectionString placeholder instead of instrumentationKey
CHANGELOG.md Documents the JavaScript SDK version upgrade

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Member

@harsimar harsimar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A note for later - is there a way to automate the updating of the snippet

@rajkumar-rangaraj rajkumar-rangaraj merged commit 9732a20 into main Jan 21, 2026
22 checks passed
@rajkumar-rangaraj rajkumar-rangaraj deleted the rajrang/updateJS branch January 21, 2026 17:51
This was referenced Feb 1, 2026
This was referenced Feb 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants