Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove two unnecessary .NET Standard 1.x dependencies. #2613

Merged
merged 3 commits into from
Jun 29, 2022
Merged

Remove two unnecessary .NET Standard 1.x dependencies. #2613

merged 3 commits into from
Jun 29, 2022

Conversation

teo-tsirpanis
Copy link
Contributor

Fix Issue N/A.

Changes

System.Diagnostics.StackTrace and TraceSource are not needed in projects that target .NET Standard 2.0. Referencing them substantially increases the transitive dependencies.

Checklist

  • I ran Unit Tests locally. - couldn't because I was getting errors CS7034 - seem unrelated to my change
  • CHANGELOG.md updated with one line description of the fix, and a link to the original issue if available.

For significant contributions please make sure you have completed the following items:

  • Design discussion issue #
  • Changes in public surface reviewed

The PR will trigger build, unit tests, and functional tests automatically. Please follow these instructions to build and test locally.

Notes for authors:

  • FxCop and other analyzers will fail the build. To see these errors yourself, compile localy using the Release configuration.

Notes for reviewers:

  • We support comment build triggers
    • /AzurePipelines run will queue all builds
    • /AzurePipelines run <pipeline-name> will queue a specific build

teo-tsirpanis and others added 3 commits June 22, 2022 15:38
System.Diagnostics.StackTrace and TraceSource are not needed in projects that target .NET Standard 2.0. Referencing them substantially increases the transitive dependencies.
@TimothyMothra TimothyMothra enabled auto-merge (squash) June 29, 2022 19:03
@TimothyMothra
Copy link
Member

@teo-tsirpanis Thank you!

@TimothyMothra TimothyMothra merged commit a2b56d5 into microsoft:main Jun 29, 2022
@teo-tsirpanis teo-tsirpanis deleted the patch-1 branch June 29, 2022 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants