Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use appropriate namespace for NoOpTelemetryModule. #2442

Merged
merged 5 commits into from
May 11, 2022

Conversation

ddunkin
Copy link
Contributor

@ddunkin ddunkin commented Oct 17, 2021

Changes

Use appropriate Microsoft namespace for NoOpTelemetryModule. The Shared.Implementation namespace causes compile errors for any project that references the Microsoft.ApplicationInsights.AspNetCore package and has a type named Shared, even though there are no public types in the namespace.

Checklist

  • I ran Unit Tests locally.
  • CHANGELOG.md updated with one line description of the fix, and a link to the original issue if available.

For significant contributions please make sure you have completed the following items:

  • Design discussion issue #
  • Changes in public surface reviewed

The PR will trigger build, unit tests, and functional tests automatically. Please follow these instructions to build and test locally.

Notes for authors:

  • FxCop and other analyzers will fail the build. To see these errors yourself, compile localy using the Release configuration.

Notes for reviewers:

  • We support comment build triggers
    • /AzurePipelines run will queue all builds
    • /AzurePipelines run <pipeline-name> will queue a specific build

The Shared.Implementation namespace causes compile errors for any project that references the Microsoft.ApplicationInsights.AspNetCore package and has a type named Shared.
@ghost
Copy link

ghost commented Oct 17, 2021

CLA assistant check
All CLA requirements met.

@ddunkin ddunkin marked this pull request as ready for review October 18, 2021 13:21
@TimothyMothra
Copy link
Member

Hi @ddunkin, sorry for the delay on this.
Can you please recreate your PR against the main branch?

Not your fault, we needed to change our default branch for some compliance issues and now we're getting to these older PRs.

@TimothyMothra TimothyMothra changed the base branch from develop to main May 10, 2022 22:23
@TimothyMothra TimothyMothra enabled auto-merge (squash) May 11, 2022 21:20
@TimothyMothra TimothyMothra merged commit b9733c9 into microsoft:main May 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants