Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix IndexOutOfRange in W3CUtilities.TryParseTraceId #1327

Merged
merged 2 commits into from
Nov 25, 2019
Merged

Fix IndexOutOfRange in W3CUtilities.TryParseTraceId #1327

merged 2 commits into from
Nov 25, 2019

Conversation

lmolkova
Copy link
Member

Fixes

AI (Internal): [Microsoft-ApplicationInsights-Extensibility-Web] Unknown error, message System.IndexOutOfRangeException: Index was outside the bounds of the array.
   at Microsoft.ApplicationInsights.W3C.Internal.W3CUtilities.TryGetTraceId(String legacyId, ReadOnlySpan`1& traceId)
   at Microsoft.ApplicationInsights.Web.Implementation.RequestTrackingExtensions.CreateRequestTelemetryPrivate(HttpContext platformContext)
   at Microsoft.ApplicationInsights.Web.Implementation.RequestTrackingExtensions.ReadOrCreateRequestTelemetryPrivate(HttpContext platformContext)
   at Microsoft.ApplicationInsights.Web.RequestTrackingTelemetryModule.OnBeginRequest(HttpContext context)
  at Microsoft.ApplicationInsights.Web.AspNetDiagnosticTelemetryModule.AspNetEventObserver.OnNext(KeyValuePair`2 value)

@TimothyMothra TimothyMothra added this to the 2.12 milestone Nov 25, 2019
@lmolkova lmolkova merged commit e345207 into develop Nov 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cijothomas cijothomas cijothomas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.12
Development

Successfully merging this pull request may close these issues.
3 participants
@lmolkova @cijothomas @TimothyMothra