Flush the TelemetryChannel when the logger provider is disposed #1289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cijothomas
approved these changes
Nov 6, 2019
There was a problem hiding this comment.
Can you add to changelog as well? https://github.com/microsoft/ApplicationInsights-dotnet/blob/develop/LOGGING/CHANGELOG.md
@TimothyMothra we will soon merge all changelog into a common one, right?
|
/AzurePipelines run |
1 similar comment
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
pharring
deleted the
dev/pharring/ILoggerFlushTelemetryChannelOnDispose
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automatically flush the telemetry channel when the ApplicationInsightsLoggerProvider is disposed.
This usually happens when the application calls Dispose on the ServiceProvider -- it calls Dispose on all IDisposable services that were instantiated.
This helps with Console applications that use ILogger which otherwise lose events sent just before shutdown. This works well for the InMemoryChannel but there is a long-standing issue with the ServerTelemetryChannel where Flush doesn't guarantee that all events have been transmitted. There's a TODO in the code about that.