update analyzers and fix issues (#1139)

ApplicationInsightsSDKRules.ruleset

@@ -11,6 +11,8 @@
     <Rule Id="CA1001" Action="Warning" />
     <Rule Id="CA1009" Action="Warning" />
     <Rule Id="CA1016" Action="Warning" />
+    <!-- Suppressing Message "Modify 'method' to catch a more specific exception type, or rethrow the exception" because we already catch Exceptions we care about and either log/ignore others. -->
+    <Rule Id="CA1031" Action="None" />
     <Rule Id="CA1033" Action="Warning" />
     <Rule Id="CA1049" Action="Warning" />
     <Rule Id="CA1060" Action="Warning" />
@@ -81,7 +83,9 @@
     <Rule Id="CA2207" Action="Warning" />
     <Rule Id="CA2210" Action="None" />
     <Rule Id="CA2212" Action="Warning" />
-    <Rule Id="CA2213" Action="Warning" />
+    <!-- Disabling this check "CA2213:DisposableFieldsShouldBeDisposed". 
+    This analyzer has a bug which fails the build, https://github.com/dotnet/roslyn-analyzers/issues/1815 -->
+    <Rule Id="CA2213" Action="None" />
     <Rule Id="CA2214" Action="Warning" />
     <Rule Id="CA2216" Action="Warning" />
     <Rule Id="CA2219" Action="Warning" />

src/Microsoft.ApplicationInsights/Channel/ITelemetry.cs

@@ -52,7 +52,7 @@ public interface ITelemetry
         ITelemetry DeepClone();
 
         /// <summary>
-        /// Writes serialization info about the data class of the implementing type using the given <see cref="ISerializationWriter"/>
+        /// Writes serialization info about the data class of the implementing type using the given <see cref="ISerializationWriter"/>.
         /// </summary>
         void SerializeData(ISerializationWriter serializationWriter);
     }

src/Microsoft.ApplicationInsights/Channel/InMemoryTransmitter.cs

@@ -6,12 +6,13 @@ namespace Microsoft.ApplicationInsights.Channel
 {
     using System;
     using System.Collections.Generic;
+    using System.Diagnostics.CodeAnalysis;
     using System.Globalization;
     using System.Threading;
     using System.Threading.Tasks;
-    using Extensibility;
-    using Extensibility.Implementation;
-    using Extensibility.Implementation.Tracing;
+    using Microsoft.ApplicationInsights.Extensibility;
+    using Microsoft.ApplicationInsights.Extensibility.Implementation;
+    using Microsoft.ApplicationInsights.Extensibility.Implementation.Tracing;
 
     /// <summary>
     /// A transmitter that will immediately send telemetry over HTTP. 
@@ -32,7 +33,6 @@ internal class InMemoryTransmitter : IDisposable
         /// The number of times this object was disposed.
         /// </summary>
         private int disposeCount = 0;
-
         private TimeSpan sendingInterval = TimeSpan.FromSeconds(30);
         private Uri endpointAddress = new Uri(Constants.TelemetryServiceEndpoint);
 

src/Microsoft.ApplicationInsights/Channel/Transmission.cs

@@ -167,7 +167,7 @@ public virtual async Task<HttpWebResponseWrapper> SendAsync()
                                     wrapper = new HttpWebResponseWrapper
                                     {
                                         StatusCode = (int)response.StatusCode,
-                                        StatusDescription = response.ReasonPhrase // maybe not required?
+                                        StatusDescription = response.ReasonPhrase, // maybe not required?
                                     };
                                     wrapper.RetryAfterHeader = response.Headers?.RetryAfter?.ToString();
 
@@ -204,7 +204,7 @@ public virtual async Task<HttpWebResponseWrapper> SendAsync()
                     {                        
                         wrapper = new HttpWebResponseWrapper
                         {
-                            StatusCode = (int)HttpStatusCode.RequestTimeout
+                            StatusCode = (int)HttpStatusCode.RequestTimeout,
                         };
                     }
 

src/Microsoft.ApplicationInsights/DataContracts/ExceptionDetailsInfo.cs

@@ -32,7 +32,7 @@ public ExceptionDetailsInfo(int id, int outerId, string typeName, string message
                 message = message,
                 hasFullStack = hasFullStack,
                 stack = stack,
-                parsedStack = parsedStack.Select(ps => ps.Data).ToList()
+                parsedStack = parsedStack.Select(ps => ps.Data).ToList(),
             };
         }
 

src/Microsoft.ApplicationInsights/DataContracts/ExceptionHandledAt.cs

@@ -21,6 +21,6 @@ public enum ExceptionHandledAt
         /// <summary>
         /// Exception was handled by some platform handlers.
         /// </summary>
-        Platform
+        Platform,
     }
 }

src/Microsoft.ApplicationInsights/DataContracts/ExceptionInfo.cs

@@ -3,8 +3,8 @@
     using System.Collections.Concurrent;
     using System.Collections.Generic;
     using System.Linq;
-    using Extensibility.Implementation;
-    using Extensibility.Implementation.External;
+    using Microsoft.ApplicationInsights.Extensibility.Implementation;
+    using Microsoft.ApplicationInsights.Extensibility.Implementation.External;
 
     /// <summary>
     /// Wrapper class for <see cref="ExceptionData"/> that lets user provide exception data without having the actual Exception object.
@@ -14,7 +14,7 @@ internal sealed class ExceptionInfo
         private readonly ExceptionData data;
 
         /// <summary>
-        /// Constructs the instance of <see cref="ExceptionInfo"/>
+        /// Constructs the instance of <see cref="ExceptionInfo"/>.
         /// </summary>
         public ExceptionInfo(IEnumerable<ExceptionDetailsInfo> exceptionDetailsInfoList, SeverityLevel? severityLevel, string problemId,
             IDictionary<string, string> properties, IDictionary<string, double> measurements)
@@ -25,7 +25,7 @@ public ExceptionInfo(IEnumerable<ExceptionDetailsInfo> exceptionDetailsInfoList,
                 severityLevel = severityLevel.TranslateSeverityLevel(),
                 problemId = problemId,
                 properties = new ConcurrentDictionary<string, string>(properties),
-                measurements = new ConcurrentDictionary<string, double>(measurements)
+                measurements = new ConcurrentDictionary<string, double>(measurements),
             };
         }
 

src/Microsoft.ApplicationInsights/DataContracts/PerformanceCounterTelemetry.cs

@@ -3,7 +3,7 @@
     using System;
     using System.Collections.Generic;
 
-    using Channel;
+    using Microsoft.ApplicationInsights.Channel;
     using Microsoft.ApplicationInsights.Extensibility;
 
     /// <summary>

src/Microsoft.ApplicationInsights/DataContracts/SessionState.cs

@@ -18,7 +18,7 @@ public enum SessionState
         /// <summary>
         /// Indicates that a user session ended.
         /// </summary>
-        End
+        End,
     }
 #pragma warning restore CA1724
 }

src/Microsoft.ApplicationInsights/DataContracts/StackFrame.cs

@@ -18,7 +18,7 @@ public StackFrame(string assembly, string fileName, int level, int line, string
                 fileName = fileName,
                 level = level,
                 line = line,
-                method = method
+                method = method,
             };
         }
 

src/Microsoft.ApplicationInsights/Extensibility/IApplicationIdProvider.cs

@@ -6,13 +6,13 @@
     public interface IApplicationIdProvider
     {
         /// <summary>
-        /// Retrieves the Application Id to be used for Request.Source or Dependency.Target
+        /// Retrieves the Application Id to be used for Request.Source or Dependency.Target.
         /// </summary>
         /// <remarks>
         /// Application Insights data model defines two fields: request.source and dependency.target. 
         /// The first field identifies the component that initiated the dependency request, 
         /// and the second identifies which component returned the response of the dependency call.
-        /// For more information see: https://docs.microsoft.com/azure/application-insights/application-insights-correlation
+        /// For more information see: https://docs.microsoft.com/azure/application-insights/application-insights-correlation .
         /// </remarks>
         /// <param name="instrumentationKey">Instrumentation Key string used to lookup associated Application Id.</param>
         /// <param name="applicationId">Application Id corresponding to the Instrumentation Key. Returns NULL if a match was not found.</param>

src/Microsoft.ApplicationInsights/Extensibility/ISerializableWithWriter.cs

@@ -1,12 +1,12 @@
 namespace Microsoft.ApplicationInsights.Extensibility
 {
     /// <summary>
-    /// Interface for defining objects which can be serialized with a given <see cref="ISerializationWriter"/>
+    /// Interface for defining objects which can be serialized with a given <see cref="ISerializationWriter"/>.
     /// </summary>
     public interface ISerializableWithWriter
     {
         /// <summary>
-        /// Writes serialization info about the class using the given <see cref="ISerializationWriter"/>
+        /// Writes serialization info about the class using the given <see cref="ISerializationWriter"/>.
         /// </summary>
         void Serialize(ISerializationWriter serializationWriter);
     }

src/Microsoft.ApplicationInsights/Extensibility/ISerializationWriter.cs

@@ -9,62 +9,62 @@
     public interface ISerializationWriter
     {
         /// <summary>
-        /// Writes name and value for a string field
+        /// Writes name and value for a string field.
         /// </summary>
         void WriteProperty(string name, string value);
 
         /// <summary>
-        /// Writes name and value for a double field
+        /// Writes name and value for a double field.
         /// </summary>
         void WriteProperty(string name, double? value);
 
         /// <summary>
-        /// Writes name and value for a int field
+        /// Writes name and value for a int field.
         /// </summary>
         void WriteProperty(string name, int? value);
 
         /// <summary>
-        /// Writes name and value for a boolean field
+        /// Writes name and value for a boolean field.
         /// </summary>
         void WriteProperty(string name, bool? value);
 
         /// <summary>
-        /// Writes name and value for a TimeSpan field
+        /// Writes name and value for a TimeSpan field.
         /// </summary>
         void WriteProperty(string name, TimeSpan? value);
 
         /// <summary>
-        /// Writes name and value for a DateTimeOffset field
+        /// Writes name and value for a DateTimeOffset field.
         /// </summary>
         void WriteProperty(string name, DateTimeOffset? value);
 
         /// <summary>
-        /// Writes name and value for a ISerializableWithWriter field
+        /// Writes name and value for a ISerializableWithWriter field.
         /// </summary>
         void WriteProperty(string name, ISerializableWithWriter value);
 
         /// <summary>
-        /// Writes value ISerializableWithWriter field
+        /// Writes value ISerializableWithWriter field.
         /// </summary>
         void WriteProperty(ISerializableWithWriter value);
 
         /// <summary>
-        /// Writes name and values for a IList field of strings
+        /// Writes name and values for a IList field of strings.
         /// </summary>
         void WriteProperty(string name, IList<string> items);
 
         /// <summary>
-        /// Writes name and values for a IList field of objects implementing ISerializableWithWriter
+        /// Writes name and values for a IList field of objects implementing ISerializableWithWriter.
         /// </summary>
         void WriteProperty(string name, IList<ISerializableWithWriter> items);
 
         /// <summary>
-        /// Writes name and value for a IDictionary field with string,string as key,value
+        /// Writes name and value for a IDictionary field with string,string as key,value.
         /// </summary>
         void WriteProperty(string name, IDictionary<string, string> items);
 
         /// <summary>
-        /// Writes name and value for a IDictionary field with string,string as key,value
+        /// Writes name and value for a IDictionary field with string,string as key,value.
         /// </summary>
         void WriteProperty(string name, IDictionary<string, double> items);
 

src/Microsoft.ApplicationInsights/Extensibility/Implementation/ApplicationId/ApplicationIdHelper.cs

@@ -7,7 +7,7 @@
     internal static class ApplicationIdHelper
     {
         /// <summary>
-        /// special string which describes that ID was taken from Breeze
+        /// special string which describes that ID was taken from Breeze.
         /// </summary>
         private const string Format = "cid-v1:{0}";
 
@@ -83,7 +83,7 @@ private static string EnforceMaxLength(string input, int maxLength)
         /// ASCII Extended characters (hex: 0x80 - 0xFF) (decimal: 128-255) (NOT ALLOWED)
         /// Non-Printable ASCII characters are (hex: 0x00 - 0x1F) (decimal: 0-31) (NOT ALLOWED)
         /// Printable ASCII characters are (hex: 0x20 - 0xFF) (decimal: 32-255) (PARTIALLY ALLOWED)
-        /// ALLOWED characters are (hex: 0x20 - 0x7F) (decimal: 32-127)
+        /// ALLOWED characters are (hex: 0x20 - 0x7F) (decimal: 32-127).
         /// </summary>
         private static bool IsCharHeaderSafe(char ch) => (uint)(ch - 0x20) <= (0x7F - 0x20);
     }

src/Microsoft.ApplicationInsights/Extensibility/Implementation/ApplicationId/ApplicationInsightsApplicationIdProvider.cs

@@ -2,9 +2,9 @@
 {
     using System;
     using System.Collections.Concurrent;
-    using System.Threading;
     using System.Threading.Tasks;
-    using Extensibility;
+
+    using Microsoft.ApplicationInsights.Extensibility;
 
     /// <summary>
     /// This <see cref="ApplicationInsightsApplicationIdProvider"/> will query the Application Insights' Breeze endpoint to lookup an Application Id based on Instrumentation Key.
@@ -42,7 +42,7 @@ internal ApplicationInsightsApplicationIdProvider(ProfileServiceWrapper profileS
 
         /// <summary>
         /// Gets or sets the endpoint that is to be used to get the Application Insights resource's profile (Application Id etc.). 
-        /// Default value is "https://dc.services.visualstudio.com/api/profiles/{0}/appId". If this is overwritten, MUST include the '{0}' for string replacement!
+        /// Default value is "https://dc.services.visualstudio.com/api/profiles/{0}/appId". If this is overwritten, MUST include the '{0}' for string replacement!.
         /// </summary>
         public string ProfileQueryEndpoint
         {
@@ -51,7 +51,7 @@ public string ProfileQueryEndpoint
         }
 
         /// <summary>
-        /// Disposes resources
+        /// Disposes resources.
         /// </summary>
         public void Dispose()
         {

src/Microsoft.ApplicationInsights/Extensibility/Implementation/ApplicationId/DictionaryApplicationIdProvider.cs

@@ -8,7 +8,7 @@
     public class DictionaryApplicationIdProvider : IApplicationIdProvider
     {
         /// <summary>
-        /// Gets or sets a dictionary of Instrumentation Keys to Application Ids
+        /// Gets or sets a dictionary of Instrumentation Keys to Application Ids.
         /// </summary>
         public IReadOnlyDictionary<string, string> Defined { get; set; }
 

src/Microsoft.ApplicationInsights/Extensibility/Implementation/ApplicationId/FailedRequestsManager.cs

@@ -3,7 +3,7 @@
     using System;
     using System.Collections.Concurrent;
     using System.Net;
-    using Extensibility.Implementation.Tracing;
+    using Microsoft.ApplicationInsights.Extensibility.Implementation.Tracing;
 
     internal class FailedRequestsManager
     {
@@ -104,7 +104,7 @@ private class FailedResult
             /// <summary>
             /// Initializes a new instance of the <see cref="FailedResult" /> class.
             /// </summary>
-            /// <param name="retryAfter">Time to wait before a retry</param>
+            /// <param name="retryAfter">Time to wait before a retry.</param>
             /// <param name="httpStatusCode">Failure response code. Used to determine if we should retry requests.</param>
             public FailedResult(TimeSpan retryAfter, HttpStatusCode httpStatusCode = HttpStatusCode.OK)
             {

src/Microsoft.ApplicationInsights/Extensibility/Implementation/ApplicationId/ProfileServiceWrapper.cs

@@ -5,7 +5,7 @@
     using System.Globalization;
     using System.Net.Http;
     using System.Threading.Tasks;
-    using Extensibility;
+    using Microsoft.ApplicationInsights.Extensibility;
 
     internal class ProfileServiceWrapper : IDisposable
     {

src/Microsoft.ApplicationInsights/Extensibility/Implementation/BroadcastProcessor.cs

@@ -75,7 +75,7 @@ public TelemetryDispatcher(TelemetrySink sink, bool cloneBeforeDispatch)
             }
 
             /// <summary>
-            /// Sends the item to sink. If cloning of item is required, clones the item before sending it to <see cref="TelemetrySink"/>
+            /// Sends the item to sink. If cloning of item is required, clones the item before sending it to <see cref="TelemetrySink"/>.
             /// </summary>
             /// <param name="telemetry">The telemetry item to send to sink.</param>
             public void SendItemToSink(ITelemetry telemetry)

src/Microsoft.ApplicationInsights/Extensibility/Implementation/ExceptionConverter.cs

@@ -37,7 +37,7 @@ internal static External.StackFrame GetStackFrame(StackFrame stackFrame, int fra
         {
             var convertedStackFrame = new External.StackFrame()
             {
-                level = frameId
+                level = frameId,
             };
 
             var methodInfo = stackFrame.GetMethod();

src/Microsoft.ApplicationInsights/Extensibility/Implementation/External/AvailabilityDataISerializableWithWriter.cs

@@ -5,7 +5,7 @@
     using Microsoft.ApplicationInsights.DataContracts;
 
     /// <summary>
-    /// Partial class to implement ISerializableWithWriter
+    /// Partial class to implement ISerializableWithWriter.
     /// </summary>
     internal partial class AvailabilityData : ISerializableWithWriter
     {

src/Microsoft.ApplicationInsights/Extensibility/Implementation/External/DataPointIExtension.cs

@@ -3,7 +3,7 @@
     using Microsoft.ApplicationInsights.DataContracts;
 
     /// <summary>
-    /// Partial class to implement ISerializableWithWriter
+    /// Partial class to implement ISerializableWithWriter.
     /// </summary>
     internal partial class DataPoint : ISerializableWithWriter
     {       

src/Microsoft.ApplicationInsights/Extensibility/Implementation/External/EventDataISerializableWithWriter.cs

@@ -5,7 +5,7 @@
     using Microsoft.ApplicationInsights.DataContracts;
 
     /// <summary>
-    /// Partial class to implement ISerializableWithWriter
+    /// Partial class to implement ISerializableWithWriter.
     /// </summary>
     internal partial class EventData : ISerializableWithWriter
     {

src/Microsoft.ApplicationInsights/Extensibility/Implementation/External/ExceptionDataISerializableWithWriter.cs

@@ -7,7 +7,7 @@
     using Microsoft.ApplicationInsights.DataContracts;
 
     /// <summary>
-    /// Partial class to implement ISerializableWithWriter
+    /// Partial class to implement ISerializableWithWriter.
     /// </summary>
     internal partial class ExceptionData : ISerializableWithWriter
     {

src/Microsoft.ApplicationInsights/Extensibility/Implementation/External/ExceptionDetailsImplementation.cs

@@ -21,7 +21,7 @@ internal static ExceptionDetails CreateWithoutStackInfo(Exception exception, Exc
             {
                 id = exception.GetHashCode(),
                 typeName = exception.GetType().FullName,
-                message = exception.Message
+                message = exception.Message,
             };
 
             if (parentExceptionDetails != null)