Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added application insights starter for spring boot #518

Merged
merged 15 commits into from
Mar 15, 2018
Merged

Added application insights starter for spring boot #518

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
9bc3711
Added application insights starter for spring boot
gavlyukovskiy Jan 9, 2018
dd97415
Added a way to disable default modules, added documentation and readme
gavlyukovskiy Feb 16, 2018
cce54ae
Polish readme
gavlyukovskiy Feb 17, 2018
946f04a
Added properties to disable quick pulse integration, all web modules;
gavlyukovskiy Feb 20, 2018
91f112b
Fixed bean ordering issue
gavlyukovskiy Feb 21, 2018
abeff08
Added properties for channel and new sampler, created TelemetryType e…
gavlyukovskiy Feb 25, 2018
e8f688f
Added documentation to added properties, added default values, update…
gavlyukovskiy Feb 25, 2018
ed16e55
Changed sampling configuration, added more tests for autoconfiguration
gavlyukovskiy Feb 27, 2018
83e1554
Changed constants with default values to public in order to use them …
gavlyukovskiy Feb 27, 2018
b55c467
Added explicit dependency on TelemetryConfiguration for QuickPulse bean
gavlyukovskiy Mar 1, 2018
afe1d0c
Polish
gavlyukovskiy Mar 1, 2018
579eb5c
removed classification of 401s as successful (#606)
littleaj Mar 13, 2018
dcadfc1
Merge branch 'master' into spring-boot-starter
gavlyukovskiy Mar 13, 2018
62086f3
Updated documentation regarding configuration values window
gavlyukovskiy Mar 13, 2018
a4fda92
Updated documentation of properties
gavlyukovskiy Mar 14, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions azure-application-insights-spring-boot-starter/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,16 +133,16 @@ azure.application-insights.logger.level=error
azure.application-insights.channel.in-process.developer-mode=false
# Endpoint address, Default value: https://dc.services.visualstudio.com/v2/track.
azure.application-insights.channel.in-process.endpoint-address=https://dc.services.visualstudio.com/v2/track
# Maximum count of telemetries that will be batched before sending. Default value: 500.
# Maximum count of telemetries that will be batched before sending. Must be between 1 and 1000. Default value: 500.
azure.application-insights.channel.in-process.max-telemetry-buffer-capacity=500
# Interval to send telemetry. Default value: 5 seconds.
# Interval to send telemetry. Must be between 1 and 300. Default value: 5 seconds.
azure.application-insights.channel.in-process.flush-interval-in-seconds=5
# Size of disk that we can use. Default value: 10 megabytes.
# Size of disk that we can use. Must be between 1 and 1000. Default value: 10 megabytes.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does't the default and maximum value both seem to be too low. What do you think? Should we bump up this capacity?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually I don't really know what is this property about at all :) probably it's a question to @littleaj that have bumped maximum value from 100 to 1000 recently.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gavlyukovskiy this property is used for disk persistence. When the network fails the telemetry gets stored in the disk and when it is restored we transmit that telemetry to the cloud.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dhaval24 nice to know, added your explanation to the documentation :)

azure.application-insights.channel.in-process.max-transmission-storage-files-capacity-in-mb=10
# Enable/Disable throttling on sending telemetry data. Default value: true.
azure.application-insights.channel.in-process.throttling=true

# Percent of telemetry events that will be sent to Application Insights. Default value: 100% (all telemetry events).
# Percent of telemetry events that will be sent to Application Insights. Must be between 0.0 and 100.0. Default value: 100 (all telemetry events).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add this comment here :
"All sampling percentage must be in a ratio of 100/N where N is a whole number (2, 3, 4, …). E.g. 50 for 1/2 or 33.33 for 1/3.
* Failure to follow this pattern can result in unexpected / incorrect computation of values in the portal."

This is important. We can only set specific sampling percentages for UI to be consistent

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't understand, can it be 2/3?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so 100/N = Sampling ratio.
Eg 100/2 = 50
100/3 = 33
100/4 = 25
100/5 = 20
100/10 = 10 etc.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably we can create property for N instead? It would be less error prone if we say that N must be between 1 (100%) and 100 (1%).

what about 0%, is it valid?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just read the documentation for .NET, it can be 1000 (0.1%) as well. Looks really odd to me, I mean that 1/3 is not really 33 or 33.3 or 33.33, it's 33.(3) which you can properly specify in properties and for this reason per documentation I have to chose closest percentage to 100/N.

azure.application-insights.telemetry-processor.sampling.percentage=100
# If set only telemetry of specified types will be included. Default value: all telemetries are included;
azure.application-insights.telemetry-processor.sampling.include=
Expand Down
8 changes: 4 additions & 4 deletions ...r/src/main/java/com/microsoft/applicationinsights/boot/ApplicationInsightsProperties.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,15 +160,15 @@ static class InProcess {
*/
private String endpointAddress = TransmissionNetworkOutput.DEFAULT_SERVER_URI;
/**
* Maximum count of telemetries that will be batched before sending.
* Maximum count of telemetries that will be batched before sending. Must be between 1 and 1000.
*/
private int maxTelemetryBufferCapacity = InProcessTelemetryChannel.DEFAULT_MAX_TELEMETRY_BUFFER_CAPACITY;
/**
* nterval to send telemetry.
* Interval to send telemetry. Must be between 1 and 300.
*/
private int flushIntervalInSeconds = InProcessTelemetryChannel.DEFAULT_FLUSH_BUFFER_TIMEOUT_IN_SECONDS;
/**
* Size of disk that we can use.
* Size of disk that we can use. Must be between 1 and 1000.
*/
private int maxTransmissionStorageFilesCapacityInMb = TransmissionFileSystemOutput.DEFAULT_CAPACITY_MEGABYTES;
/**
Expand Down Expand Up @@ -243,7 +243,7 @@ public void setSampling(Sampling sampling) {

static class Sampling {
/**
* Percent of telemetry events that will be sent to Application Insights.
* Percent of telemetry events that will be sent to Application Insights. Must be between 0.0 and 100.0.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same sampling comment here.

*/
private double percentage = FixedRateSamplingTelemetryProcessor.DEFAULT_SAMPLING_PERCENTAGE;
/**
Expand Down