Suppress duplicate AI agents #1434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kryalama
reviewed
Jan 12, 2021
...ava/com/microsoft/applicationinsights/agent/internal/DuplicateAgentClassFileTransformer.java
Outdated
Show resolved
Hide resolved
heyams
reviewed
Jan 12, 2021
ya, you're right, this is important, I added a backlog item to add test: https://msazure.visualstudio.com/One/_workitems/edit/9112258 |
heyams
approved these changes
Jan 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes sure that, as long as the 3.0.0 java agent is the first
-javaagenton the command line, that it will suppress other Application Insights java agents.This is primarily helpful for App Services attach, where we use
JAVA_TOOL_OPTIONS(which is prepended to the command line args).This also resolves #1345 😄 (https://stackoverflow.com/questions/60838748/intellij-idea-java-instrumentation-premain-gets-called-twice-when-directly-run).