spotbugs

microsoft · Jul 28, 2022 · a837346 · a837346
1 parent 8f29d55
commit a837346
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/legacy-sdk/core/build.gradle.kts b/legacy-sdk/core/build.gradle.kts
@@ -6,3 +6,7 @@ plugins {
 }
 
 base.archivesName.set("applicationinsights-core")
+
+dependencies {
+  compileOnly("com.github.spotbugs:spotbugs-annotations")
+}
diff --git a/...core/src/main/java/com/microsoft/applicationinsights/internal/util/LocalStringsUtils.java b/...core/src/main/java/com/microsoft/applicationinsights/internal/util/LocalStringsUtils.java
@@ -21,12 +21,12 @@
 
 package com.microsoft.applicationinsights.internal.util;
 
+import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 import java.text.DateFormat;
 import java.text.SimpleDateFormat;
 import java.util.concurrent.ThreadLocalRandom;
 
 public class LocalStringsUtils {
-  private LocalStringsUtils() {} // no instances please
 
   /**
    * Determine whether a string is null or empty.
@@ -38,6 +38,9 @@ public static boolean isNullOrEmpty(String value) {
     return value == null || value.isEmpty();
   }
 
+  @SuppressFBWarnings(
+      value = "SECPR", // Predictable pseudorandom number generator
+      justification = "Predictable random is ok for telemetry id")
   public static String generateRandomIntegerId() {
     // avoid using Math.abs(rand.nextLong()) because Math.abs(Long.MIN_VALUE) is negative
     long rand = ThreadLocalRandom.current().nextLong(Long.MAX_VALUE);
@@ -47,4 +50,6 @@ public static String generateRandomIntegerId() {
   public static DateFormat getDateFormatter() {
     return new SimpleDateFormat("yyyy-MM-dd'T'HH:mm:ss.SSSZZ");
   }
+
+  private LocalStringsUtils() {}
 }