Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compile error for Unity build #3351

Merged
merged 2 commits into from
Feb 2, 2021

Conversation

niekvleeuwen
Copy link
Contributor

About

@zimmy87 Follow up on #3102. I noticed that the Unity build of my previous pull request was failing. At the time I commited this feature the Github Actions were not present, so I didn't notice the failing build. This pull request fixes this failing Unity build.

@rajat2004
Copy link
Contributor

@niekvleeuwen Another thing I noticed, the docstring mentions the type as float, but it should be an integer

@niekvleeuwen
Copy link
Contributor Author

@rajat2004 Thanks for noticing! I updated my branch to fix the incorrect docstring.

@zimmy87
Copy link
Contributor

zimmy87 commented Feb 2, 2021

thanks for catching and fixing this @niekvleeuwen!

@zimmy87 zimmy87 merged commit 3d1195e into microsoft:master Feb 2, 2021
@niekvleeuwen niekvleeuwen deleted the fix-continueForFrames branch February 2, 2021 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants