Only install packages if required on OSX #3273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
zimmy87
reviewed
Jan 7, 2021
There was a problem hiding this comment.
Hi @rajat2004 we have a question that we'd like addressed before approving this PR for merging.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: MacOS Actions CI
About
Currently, the MacOS build is giving error -
Error: wget 1.20.3_2 is already installed. This modifies the script to only install the package if required. Based on thisRecommended way is to use homebrew-bundle, but I haven't ever used it and might be a bit overkill, but let me know if that's the better way to go.
How Has This Been Tested?
Github Actions CI
Screenshots (if appropriate):