Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Faster Image Capture #2713

Closed
wants to merge 30 commits into from
Closed

Faster Image Capture #2713

wants to merge 30 commits into from

Commits on Mar 25, 2020

  1. Fast capture prototype.

    @madratman
    Nicholas Gyde (Collabera) authored and madratman committed Mar 25, 2020
    Configuration menu
    Copy the full SHA
    68297b5 View commit details
    Browse the repository at this point in the history

  2. Image capture is functional but needs optimization and cleanup.

    @madratman
    Nicholas Gyde (Collabera) authored and madratman committed Mar 25, 2020
    Configuration menu
    Copy the full SHA
    f539dbf View commit details
    Browse the repository at this point in the history

  3. Improvements to image capture speedup

    @madratman
    Nicholas Gyde (Collabera) authored and madratman committed Mar 25, 2020
    Configuration menu
    Copy the full SHA
    57602f6 View commit details
    Browse the repository at this point in the history

  4. Cleaned up fast img capture, but it's less faster for some reason.

    @madratman
    Nicholas Gyde (Collabera) authored and madratman committed Mar 25, 2020
    Configuration menu
    Copy the full SHA
    8c3a757 View commit details
    Browse the repository at this point in the history

  5. remove comments for PR

    @madratman
    Nicholas Gyde (Collabera) authored and madratman committed Mar 25, 2020
    Configuration menu
    Copy the full SHA
    e899c94 View commit details
    Browse the repository at this point in the history

  6. Added buffer pool object and used for image capture. Increases speed … 

    …more. Buffer pool might be useful for other things.
    @madratman
    Nicholas Gyde (Collabera) authored and madratman committed Mar 25, 2020
    Configuration menu
    Copy the full SHA
    205ae5b View commit details
    Browse the repository at this point in the history

  7. Closer to fixing build issues

    @madratman
    Nicholas Gyde authored and madratman committed Mar 25, 2020
    Configuration menu
    Copy the full SHA
    33e73f8 View commit details
    Browse the repository at this point in the history

  8. Reinstate commented out DepthNav code

    @madratman
    Nicholas Gyde authored and madratman committed Mar 25, 2020
    Configuration menu
    Copy the full SHA
    82dbb3e View commit details
    Browse the repository at this point in the history

  9. Removed remaining build errors.

    @madratman
    Nicholas Gyde authored and madratman committed Mar 25, 2020
    Configuration menu
    Copy the full SHA
    83a6004 View commit details
    Browse the repository at this point in the history

  10. Replaced non-portable expression _CRT_SIZE_MAX

    @madratman
    Nicholas Gyde authored and madratman committed Mar 25, 2020
    Configuration menu
    Copy the full SHA
    b245d5c View commit details
    Browse the repository at this point in the history

  11. Restored height, width, and time_stamp data in image responses.

    @madratman
    Nicholas Gyde authored and madratman committed Mar 25, 2020
    Configuration menu
    Copy the full SHA
    4a502b0 View commit details
    Browse the repository at this point in the history

  12. Removed extraneous std:move() and made a portable bit strober to fix … 

    …linux issues.
    @madratman
    Nicholas Gyde authored and madratman committed Mar 25, 2020
    Configuration menu
    Copy the full SHA
    de9cf5b View commit details
    Browse the repository at this point in the history

Commits on Mar 26, 2020

  1. add image_benchmarker script

    @madratman
    madratman committed Mar 26, 2020
    Configuration menu
    Copy the full SHA
    142f860 View commit details
    Browse the repository at this point in the history

  2. [formatting] maintain whitespacing consistency with AirSim code

    @madratman
    madratman committed Mar 26, 2020
    Configuration menu
    Copy the full SHA
    1f89018 View commit details
    Browse the repository at this point in the history

Commits on Mar 27, 2020

  1. Rather than assume width is rounded up to power of two, pass the buff… 

    …er pool to the render thread so it can ask for the correct size of dest buffer when src buffer is known.
    @ironclownfish @madratman
    ironclownfish authored and madratman committed Mar 27, 2020
    Configuration menu
    Copy the full SHA
    220ad4b View commit details
    Browse the repository at this point in the history

Commits on May 6, 2020

  1. Get simGetImages working

    Nicholas Gyde committed May 6, 2020
    Configuration menu
    Copy the full SHA
    03494a5 View commit details
    Browse the repository at this point in the history

Commits on May 11, 2020

  1. A memcopy is necessary in RpcLibAdaptorsBase. A swap would send a siz… 

    …e-0 buffer back into the response's image_data_uint8, which then returns that useless buffer to the buffer pool. Since RPC can't take over the unique_ptr that manages our buffer, we should send RPC a copy.
    Nicholas Gyde committed May 11, 2020
    Configuration menu
    Copy the full SHA
    9b74b56 View commit details
    Browse the repository at this point in the history

Commits on May 16, 2020

  1. Compilation fixes

    @rajat2004
    rajat2004 committed May 16, 2020
    Configuration menu
    Copy the full SHA
    0b94b8a View commit details
    Browse the repository at this point in the history

  2. Fix camera name in benchmark script

    @rajat2004
    rajat2004 committed May 16, 2020
    Configuration menu
    Copy the full SHA
    6d7f405 View commit details
    Browse the repository at this point in the history

Commits on May 23, 2020

  1. Merge branch 'master' of https://github.com/microsoft/AirSim into pr/… 

    …2472_rebased
    @rajat2004
    rajat2004 committed May 23, 2020
    Configuration menu
    Copy the full SHA
    d70f0e0 View commit details
    Browse the repository at this point in the history

  2. Fix compile error

    @rajat2004
    rajat2004 committed May 23, 2020
    Configuration menu
    Copy the full SHA
    6b16976 View commit details
    Browse the repository at this point in the history

  3. Fix image width calculation

    @rajat2004
    rajat2004 committed May 23, 2020
    Configuration menu
    Copy the full SHA
    4603bf3 View commit details
    Browse the repository at this point in the history

  4. [Unreal] Use WriteOnly LockMode to avoid crash on Linux using Vulkan

    @rajat2004
    rajat2004 committed May 23, 2020
    Configuration menu
    Copy the full SHA
    e85fee6 View commit details
    Browse the repository at this point in the history

Commits on May 24, 2020

  1. Make no. of channles depend on image, allows it to be used on both PR… 

    … and master
    @rajat2004
    rajat2004 committed May 24, 2020
    Configuration menu
    Copy the full SHA
    b5f79e5 View commit details
    Browse the repository at this point in the history

  2. Revert "[Unreal] Use WriteOnly LockMode to avoid crash on Linux using… 

    … Vulkan"

With this modification, garbage data is returned
This reverts commit e85fee6.
    @rajat2004
    rajat2004 committed May 24, 2020
    Configuration menu
    Copy the full SHA
    92c977c View commit details
    Browse the repository at this point in the history

Commits on May 25, 2020

  1. Updated benchmark script, add save_images option

    @rajat2004
    rajat2004 committed May 25, 2020
    Configuration menu
    Copy the full SHA
    d572411 View commit details
    Browse the repository at this point in the history

Commits on May 28, 2020

  1. [Unreal] Disable camera after capturing image

    @rajat2004
    rajat2004 committed May 28, 2020
    Configuration menu
    Copy the full SHA
    3de9156 View commit details
    Browse the repository at this point in the history

  2. [Pythonclient] Add high resolution camera benchmark script

    @rajat2004
    rajat2004 committed May 28, 2020
    Configuration menu
    Copy the full SHA
    41dcd84 View commit details
    Browse the repository at this point in the history

Commits on Jun 1, 2020

  1. restore BP_FlyingPawn.uasset, fixes to benchmarking script

    @madratman
    madratman committed Jun 1, 2020
    Configuration menu
    Copy the full SHA
    6612ea4 View commit details
    Browse the repository at this point in the history

Commits on Jun 8, 2020

  1. Add image_type option to benchmark script

    @rajat2004
    rajat2004 committed Jun 8, 2020
    Configuration menu
    Copy the full SHA
    0391272 View commit details
    Browse the repository at this point in the history