-
Notifications
You must be signed in to change notification settings - Fork 550
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add supported properties to AC object models #8895
base: main
Are you sure you want to change the base?
Add supported properties to AC object models #8895
Conversation
@RichardLun please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
[XmlElement] | ||
#endif | ||
[DefaultValue(null)] | ||
public string Originator { get; set; } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you have any examples about what this Originator should look like? what is this value used for?
#if !NETSTANDARD1_3 | ||
[XmlAttribute] | ||
#endif | ||
public string Method { get; set; } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this just GET/POST?
/// </summary> | ||
public AdaptivePadding(AdaptiveSpacing left, AdaptiveSpacing top, AdaptiveSpacing right, AdaptiveSpacing bottom) | ||
{ | ||
Left = left; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is it expected to have different paddings for all directions? I think later implementation versions only allow a single value
please add Adaptive Cards samples and scenarios |
We included the Action.Http in our 1.0 beta version but ultimately decided not to incorporate it in the final release. |
Issue
We currently are generating actionable messages for Viva Pulse survey notifications using our own models, and we wanted to integrate with the .NET SDK. However, the SDK is missing certain functionality that would make it difficult to migrate.
I've found that other repos that use actionable messages have their own models and don't use the SDK, e.g. substrate, griffin, and some others. These models have in common the functionality that the models here are missing that we need. Currently this is:
In the models in substrate there is a comment that says: "This file is copied from Griffin repository temporarily until a better code sharing approach is implemented," so I think this duplication of models is an issue for others trying to generate actionable messages as well.
API surface/schema/down-level impact
The API will be extended to include new properties for actionHttp, padding, alignment, originatorId, right-to-left text support, and constrainWidth on adaptive cards. Additional methods for managing these properties are added. All new properties are ignored by serialization and deserialization when null so no existing code is affected.
How Verified