Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Spec] Plan for updating the FactSet element #7509

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

almedina-ms
Copy link
Contributor

@almedina-ms almedina-ms commented Jun 10, 2022

Related Issue

Proposal for a long lasting fix for https://microsoft.visualstudio.com/OS/_workitems/edit/37990023

Description

Add details of how to update the FactSet element to provide a general better experience for car authors

Microsoft Reviewers: Open in CodeFlow

Copy link
Member

@jwoo-msft jwoo-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If FactSet's title and value have all of the properties of TextBlock, we can also use TextBlocks as values of FactSet's title and value.

With this change, I'm wondering what benefits cards authors get when they can use Tables with TextBlocks.

@almedina-ms
Copy link
Contributor Author

If FactSet's title and value have all of the properties of TextBlock, we can also use TextBlocks as values of FactSet's title and value.

With this change, I'm wondering what benefits cards authors get when they can use Tables with TextBlocks.

I think factset cover only the scenario where you want a 2 by N table

@jwoo-msft
Copy link
Member

If FactSet's title and value have all of the properties of TextBlock, we can also use TextBlocks as values of FactSet's title and value.
With this change, I'm wondering what benefits cards authors get when they can use Tables with TextBlocks.

I think factset cover only the scenario where you want a 2 by N table

Yes, you are correct. I like the changes. My humble suggestion is we can also consider factoring out text properties and create a new property that holds all of the text properties as we do with Background Property.
And add the property to TextBlock and FactSet.

@almedina-ms
Copy link
Contributor Author

If FactSet's title and value have all of the properties of TextBlock, we can also use TextBlocks as values of FactSet's title and value.
With this change, I'm wondering what benefits cards authors get when they can use Tables with TextBlocks.

I think factset cover only the scenario where you want a 2 by N table

Yes, you are correct. I like the changes. My humble suggestion is we can also consider factoring out text properties and create a new property that holds all of the text properties as we do with Background Property. And add the property to TextBlock and FactSet.

I think this is done in code in the shared model for TextBlock and TextRuns, do you want to open that paradigm to the format of the card?

@ghost ghost added the no-recent-activity label Jun 19, 2022
@ghost
Copy link

ghost commented Jun 19, 2022

Hi @almedina-ms. This pull request has had no recent activity for the past 5 days . Please take the necessary actions (review, address feedback or commit if reviewed already) to move this along.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants