Skip to content

[UWP] Aligned UWP showcard margin with the rest of renderers #3494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Joseph Woo (jwoo-msft) merged 3 commits into from
Oct 1, 2019
Merged

[UWP] Aligned UWP showcard margin with the rest of renderers #3494

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
768ef20
Aligned UWP showcard margin with the rest of renderers
Sep 19, 2019
043e1c9
Merge branch 'master' into jwoo/uwp-showcard
Oct 1, 2019
a6cd40b
Merge branch 'master' into jwoo/uwp-showcard
Oct 1, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion source/uwp/Renderer/lib/AdaptiveShowCardActionRenderer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ namespace AdaptiveNamespace
const double negativePadding = -(static_cast<double>(padding));
const double sideMargin = negativePadding;
const double topMargin = isBottomActionBar ? inlineTopMargin + padding : inlineTopMargin;
const double bottomMargin = isBottomActionBar ? negativePadding : 0;
const double bottomMargin = negativePadding;

Thickness margin = {sideMargin, topMargin, sideMargin, bottomMargin};
RETURN_IF_FAILED(showCardFrameworkElement->put_Margin(margin));
Expand Down