Skip to content

[WPF] Avoid hiding an action in toggleVisibility #3119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
almedina-ms merged 2 commits into from
Jul 2, 2019
Merged

[WPF] Avoid hiding an action in toggleVisibility #3119

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a138e0f
Add null check to discern on element being an action
almedina-ms Jun 28, 2019
380a54c
Merge branch 'master' into user/almedina-ms/FixVisibilityActionCrash
almedina-ms Jul 2, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions source/dotnet/Library/AdaptiveCards.Rendering.Wpf/AdaptiveRenderContext.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -314,6 +314,13 @@ private TagContent GetTagContent(FrameworkElement element)
/// <param name="tagContent">Rendered element tag</param>
public void SetVisibility(FrameworkElement element, bool desiredVisibility, TagContent tagContent)
{
// TagContents are only assigned to card elements so actions mustn't have a TagContent object tied to it
// TagContents are used to save information on the rendered object as the element separator
if (tagContent == null)
{
return;
}

bool elementIsCurrentlyVisible = (element.Visibility == Visibility.Visible);

element.Visibility = desiredVisibility ? Visibility.Visible : Visibility.Collapsed;
Expand Down