Repository navigation
[TS] Template engine and integration into Designer - #2355
Closed
David Claux (dclaux) wants to merge 131 commits into
Closed
David Claux (dclaux) wants to merge 131 commits into
David Claux (dclaux) wants to merge 131 commits into
Conversation
A couple features still missing
[Designer] Minor bug fixes [Designer] Minor cosmetic changes
Add $data property to CardElement and Action Add sample data JSON editor toolbox (work in progress)
[Designer] Add CardDesigner.dataStructure property [Designer] Small cosmetic updates
Add support for JSON.parse as a function
…ference is needed
When there is an unexpanded ShowCard
| "type": "Image", | ||
| "backgroundColor": "#183774", | ||
| "url": "http://adaptivecards.io/content/cats/1.png" | ||
| }] |
There was a problem hiding this comment.
Hey David Claux (@dclaux), are the changes to teh test samples related to your changes at all? My only concern is a bad merge accidentally overwriting stuff in master for 1.2 ..
Member
Author
There was a problem hiding this comment.
I don't remember making any changes here.
| ../../shared/cpp/ObjectModel/ToggleVisibilityAction.cpp | ||
| ../../shared/cpp/ObjectModel/ToggleVisibilityTarget.cpp | ||
| ../../shared/cpp/ObjectModel/UnknownElement.cpp | ||
| ../../shared/cpp/ObjectModel/UnknownAction.cpp |
There was a problem hiding this comment.
is this by design ? This may be a bad merge conflict change?
Member
Author
There was a problem hiding this comment.
I never made this change.
David Claux (dclaux)
requested review from
Andrew Leader (andrewleader) and
Matt Hidinger (matthidinger)
May 22, 2019 23:13
Member
Author
|
Closing this PR. All the relevant changes are now in this PR: #2995 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is not finished, but is functional enough to start testing.