Pass seconds to methods which receive seconds not milliseconds #558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdelamo
changed the title
|
| @@ -223,7 +223,8 @@ public <T> CompletableFuture<T> get(Object key, Argument<T> requiredType, Suppli | |||
| Optional<T> deserialized = valueSerializer.deserialize(data, requiredType); | |||
| boolean hasValue = deserialized.isPresent(); | |||
| if (expireAfterAccess != null && hasValue) { | |||
| return redisKeyAsyncCommands.expire(serializedKey, expireAfterAccess).thenApply(ignore -> deserialized.get()); | |||
| final long expireAfterAccessInSeconds = expireAfterAccess / 1000; | |||
| return redisKeyAsyncCommands.expire(serializedKey, expireAfterAccessInSeconds).thenApply(ignore -> deserialized.get()); | |||
There was a problem hiding this comment.
Instead of converting to milliseconds (which could lose precision), maybe just use pexpire? (https://redis.io/docs/latest/commands/pexpire/)
Update - or I guess you mention something about pexpire in the PR description, but it isn't clear to me why not to use it here instead.
There was a problem hiding this comment.
indeed , using pexpire would solve the issue rather than converting to milliseconds, I've added tests that hit the methods .
|
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close: #474
RedisAsynCommand::expiremethods takes seconds but we were passing milliseconds.There are other methods in the Redis API, for example the
RedisAsynCommand::pexpirewhich takes milliseconds. Our tests, were hitting that method. That it is the reason why they were passing.This PR converts from milliseconds to seconds the methods that require seconds and it adds tests for those code paths.