build: update to Micronaut 4 #331
Conversation
|
@timyates could you look into this? |
|
Still failing, I suspect it's an issue in core |
Previously conversion from a byte[] would return Optional.empty This would trigger the deserialization from the value in the attribute map Now conversion would return a String (which would be the JSON representation of the object) So we end up with strings in the session wrapped in double quotes. This change gets the value as an Object type, and if this is a byte array, deserializes it from JSON
|
@sdelamo Fixed. I had to pass the ConversionService in to the RedisSessionStore, as previously conversion from a byte[] would return Optional.empty. This would trigger the deserialization from the value in the attribute map. Now in Micronaut 4.0.0, conversion returns a String (which would be the JSON representation of the object), so we ended up with strings in the session wrapped in double quotes. (@graemerocher does this look ok?) This change gets the value as an Object type, and if this is a byte array, deserializes it from JSON as we used to rely on the value being null conversion context not being able to , which meant I had to change the public constructor After a discussion in the meeting, there was no preference to simply making the change over deprecating the old constructor, so I went with the former and added it to the accepted-api-changes |
|
Kudos, SonarCloud Quality Gate passed! |
No description provided.