Address feedback for connection pool #274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This addresses the feedback from @sdelamo in #273 Two items remain: 1. [don't use Optional as method parameter](https://github.com/micronaut-projects/micronaut-redis/pull/273\#discussion_r826692810) 2. [deleting this method is a breaking change](https://github.com/micronaut-projects/micronaut-redis/pull/273\#discussion_r826696245)
|
Kudos, SonarCloud Quality Gate passed! |
sdelamo
approved these changes
Mar 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses the feedback from @sdelamo in #273
One items remains:
Whilst I agree, this would mean changing every method in that class to use String and check for null. How strongly do we want this change? It would also require a major release as that class is public