Use ozimov embedded-redis #252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
guillermocalvo
approved these changes
Aug 29, 2023
There was a problem hiding this comment.
The embedded Redis container is deprecated since version 5.3.0 and will be removed eventually, in favor of test-resources.
In the meanwhile though, I don't think it hurts if we upgrade from com.github.kstyrc:embedded-redis:0.6 to it.ozimov:embedded-redis:0.7.3.
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kstyrc/embedded-redis hasn't been updated since 2018 and doesn't support redis 4+ (kstyrc/embedded-redis#90). The latest release is also missing some more recent improvements like disallowing null ports (kstyrc/embedded-redis#58).
The ozimov fork has been updated more recently and should support some of this functionality.