Support clustered redis latency metrics #244
Merged
+256
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@kandogu can you describe the PR? What issue are you trying to solve? what feature are you adding? |
sdelamo
requested changes
Mar 14, 2022
...ttuce/src/main/java/io/micronaut/configuration/lettuce/DefaultRedisClusterClientFactory.java
Show resolved
Hide resolved
|
Latency metrics are not supported in the clustered client of Redis, I was trying to add latency metrics to the clustered client too as the standalone Redis client. @sdelamo |
|
@sdelamo can you look at it again? |
guillermocalvo
suggested changes
Aug 29, 2023
There was a problem hiding this comment.
Looks good overall, except for the lack of tests.
I personally wouldn't introduce an abstract class to inherit this functionality from, because IMO it makes the implementation a bit more complicated than it needs to be. And I don't foresee many classes extending from it; I may be wrong though.
...ttuce/src/main/java/io/micronaut/configuration/lettuce/DefaultRedisClusterClientFactory.java
Outdated
Show resolved
Hide resolved
...ttuce/src/main/java/io/micronaut/configuration/lettuce/DefaultRedisClusterClientFactory.java
Outdated
Show resolved
Hide resolved
...tuce/src/main/java/io/micronaut/configuration/lettuce/AbstractRedisClusterClientFactory.java
Outdated
Show resolved
Hide resolved
...tuce/src/main/java/io/micronaut/configuration/lettuce/AbstractRedisClusterClientFactory.java
Outdated
Show resolved
Hide resolved
guillermocalvo
changed the title
guillermocalvo
added
the
type: improvement
sdelamo
approved these changes
Nov 9, 2023
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.