Added test suite for micronaut-openapi with spring-boot application. #1770
Conversation
altro3
force-pushed
the
add-spring-tests
branch
from
b208a87
to
ff5aa81
Compare
altro3
force-pushed
the
add-spring-tests
branch
from
ff5aa81
to
07c7a03
Compare
|
|
||
| // add to annotationProcessor and compileOnly blocks next libraries: | ||
|
|
||
| annotationProcessor platform("io.micronaut.platform:micronaut-platform:$micronautVersion") |
There was a problem hiding this comment.
I don't think we should promote applying the Micronaut platform BOM, they should only apply the core BOM, the spring BOM and the OpenAPI BOM
The platform BOM may conflict
There was a problem hiding this comment.
Yes, the versions may not be exactly the same, but personally I use it exactly like this and so far everything has worked fine. It's just that if you don't do it like this, you'll have to set your own version for each library or connect as many as 4 additional bomb files - core, openapi, serde and micronaut-spring.
It seems to me that it's quite normal for the first version. If users have real problems, then the example can be improved.
There was a problem hiding this comment.
so the issue is it might work for you but it is likely not to align the Spring Platform BOM which will create issues for others depending on the dependencies specified. If it is purely documentation then sure maybe it is fine, but be aware this is not going to work at scale
altro3
force-pushed
the
add-spring-tests
branch
2 times, most recently
from
57e84df
to
510dd37
Compare
|
@graemerocher could you merge all PRs? |
altro3
force-pushed
the
add-spring-tests
branch
from
510dd37
to
d500b15
Compare
altro3
force-pushed
the
add-spring-tests
branch
from
c11f3f6
to
ab1c25a
Compare
| annotationProcessor("io.micronaut.spring:micronaut-spring-annotation:$micronautSpringVersion") | ||
| annotationProcessor("io.micronaut.spring:micronaut-spring-web-annotation:$micronautSpringVersion") | ||
| annotationProcessor("io.micronaut.spring:micronaut-spring-boot-annotation:$micronautSpringVersion") |
There was a problem hiding this comment.
| annotationProcessor("io.micronaut.spring:micronaut-spring-annotation:$micronautSpringVersion") | |
| annotationProcessor("io.micronaut.spring:micronaut-spring-web-annotation:$micronautSpringVersion") | |
| annotationProcessor("io.micronaut.spring:micronaut-spring-boot-annotation:$micronautSpringVersion") | |
| annotationProcessor(platform("io.micronaut.spring:micronaut-spring-bom:$micronautSpringVersion")) | |
| annotationProcessor("io.micronaut.spring:micronaut-spring-annotation") | |
| annotationProcessor("io.micronaut.spring:micronaut-spring-web-annotation") | |
| annotationProcessor("io.micronaut.spring:micronaut-spring-boot-annotation") |
There was a problem hiding this comment.
I disagree with the suggestion. I didn't do it because such code could affect other dependencies in this block.
There was a problem hiding this comment.
Maybe I'm wrong. Ok, fixed
Added documentation how to use micronaut-openapi with Spring applications
altro3
force-pushed
the
add-spring-tests
branch
from
453a566
to
5b3d88a
Compare
altro3
force-pushed
the
add-spring-tests
branch
from
5b3d88a
to
553aa2a
Compare
Added documentation how to use micronaut-openapi with Spring applications