Add support constructor parameters annotations for schemes #1417
Conversation
altro3
changed the title
altro3
changed the title
altro3
force-pushed
the
add-support-constructor-annottions
branch
3 times, most recently
from
d6fe83b
to
92f31de
Compare
|
|
|
|
altro3
force-pushed
the
add-support-constructor-annottions
branch
2 times, most recently
from
2ff6b9b
to
48d73f0
Compare
altro3
force-pushed
the
add-support-constructor-annottions
branch
from
48d73f0
to
f6b153f
Compare
|
@altro3 you have to sign the CLA again. Sorry for the inconvenience. |
|
@sdelamo ??? What does it mean? Is this blocking the merge? What do I need to do? |
No action in your side. It appears to be a glitch with cla-assistant.io reporting. Sorry for the noise. |
|
@altro3 Can you merge master into this branch? |
altro3
force-pushed
the
add-support-constructor-annottions
branch
from
f6b153f
to
275d11f
Compare
|
@sdelamo done |
altro3
force-pushed
the
add-support-constructor-annottions
branch
from
275d11f
to
f4c8af0
Compare
| } | ||
| } | ||
| /* | ||
| 0 = {LoadedVisitor@8165} "io.micronaut.openapi.visitor.OpenApiGroupInfoVisitor@3d615b2e" |
| || isIgnoredParameterType(parameter.getType()); | ||
| } | ||
|
|
||
| private static boolean isParamAnnotationPresent(Element element, String className) { | ||
| return element.findAnnotation(className).isPresent(); |
There was a problem hiding this comment.
There is not hasAnnotation
There was a problem hiding this comment.
@dstepanov ??? What do you mean? How I need to change it?
There was a problem hiding this comment.
do I need to change it to this:
parameter.isAnnotationPresent("org.springframework.web.bind.annotation.SessionAttribute")?
There was a problem hiding this comment.
and what difference between hasAnnotation and isAnnotationPresent ?
There was a problem hiding this comment.
I think it’s better to avoid returning an optional
There was a problem hiding this comment.
I'm sorry, I still didn't get it.: Do I need to change something? If so, what should I change?
There was a problem hiding this comment.
Not a big deal, but I think the method that return a boolean is better than the optional
There was a problem hiding this comment.
@dstepanov ok, I changed it to hasAnnotation. But what difference between hasAnnotation and isAnnotationPresent ?
altro3
force-pushed
the
add-support-constructor-annottions
branch
from
f4c8af0
to
0a99752
Compare
|
@sdelamo could you merge this last PR and finalize release? |
altro3
force-pushed
the
add-support-constructor-annottions
branch
from
0a99752
to
6690467
Compare
|
@altro3 can you merge master into this branch? |
altro3
force-pushed
the
add-support-constructor-annottions
branch
from
6690467
to
bfddeaf
Compare
|
@sdelamo done |
No description provided.