Get more versions from version catalogs. #880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sdelamo review this PR, pls |
sdelamo
requested changes
Apr 18, 2024
| @@ -0,0 +1,12 @@ | |||
| plugins { | |||
There was a problem hiding this comment.
why are you renaming to build-logic? We should be consistent in every module and we use buildSrc everywhere. Please, revert it to buildSrc . Let's try to do small PRs without mixing several things.
There was a problem hiding this comment.
I thought that now you use build-logic everywhere, because that’s what I see now in micronaut-openapi. I thought that everything needed to be brought to one form. I don’t know why in micronaut-openapi this folder was renamed to build-logic
There was a problem hiding this comment.
Please, use buildSrc in this Pr. Thanks.
Corrections in gradle scripts Update libs
|
@sdelamo Hm... I remembered what the problem was specifically in this module until I changed the name of buildSrc to build-logic. If I revert rename module buildSrc to build-logic now I have this error: Problem in this change: Now in buildSrc 2 gradle plugins for Kotlin are added in the implementation block. Our task is to get rid of duplication of versions of these plugins and take them from the core version catalog. As you can see, I managed to do this. If I leave a directory named buildSrc then I get the error I described above. But the problem is not only this, but the fact that I CANNOT add plugins from the plugins catalog to the implementation block. I think this has something to do with the fact that buildSrc is the gradle system directory, which it handles slightly differently than if you do it in a plugin like build-logic Well, you need to decide what is more important: duplication of versions or the name of the directory. Or is there some more correct solution so that you don’t have to rename directories and remove duplication of versions. PS Add @melix to this project pls, can't tag him |
|
But maybe now it is problem in build plugin: |
sdelamo
added
the
relates-to: build
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corrections in gradle scripts
Update libs