Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update managed.grpc to v1.61.0 - abandoned #821

Merged
merged 3 commits into from
Jan 18, 2024

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Dec 10, 2023

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
io.grpc:grpc-bom 1.59.1 -> 1.61.0 age adoption passing confidence
io.grpc:protoc-gen-grpc-java 1.59.1 -> 1.61.0 age adoption passing confidence
io.grpc:grpc-services 1.59.1 -> 1.61.0 age adoption passing confidence
io.grpc:grpc-stub 1.59.1 -> 1.61.0 age adoption passing confidence
io.grpc:grpc-protobuf 1.59.1 -> 1.61.0 age adoption passing confidence

Release Notes

grpc/grpc-java (io.grpc:grpc-bom)

v1.61.0

v1.60.1

Bug Fixes
  • util: Fix NPE when multiple addresses in an address group for petiole load balancer policies (#​10770)

v1.60.0

API Changes
  • api: Stabilize ForwardingServerBuilder, ForwardingChannelBuilder2, and ForwardingChannelBuilder. Note that ForwardingChannelBuilder is stabilized (no changes will be made to it), but immediately deprecated in favor of ForwardingChannelBuilder2. (#​10586)
  • api: Deprecate ForwardingChannelBuilder.delegate(). De facto this deprecates the class itself, since all classes extending ForwardingChannelBuilder implement the delegate() method. See javadoc for details (#​10587)
  • api: Changed recently-introduced LoadBalancer.acceptResolvedAddresses() to return Status instead of boolean (#​10636). This is part of continued work to align the LB API cross-language and API stabilization
  • stub: Deprecate StreamObservers (#​10654)
  • alts: AltsChannelBuilder now extends ForwardingChannelBuilder2 (#​10587)
  • protobuf: Stabilize ProtoUtils.metadataMarshaller() (#​10628)
  • protobuf-lite: ProtoLiteUtils experimental comment (#​10627)
Behavior Changes
  • core: ManagedChannels now check the address types provided by the nameResolver (for the given target) with the address types supported by the channel transport and generate an error in case of mismatch. That dramatically improves the error message when an issue occurs
  • core: When a server stream is closed due to user's code (an uncaught exception in halfClosed, messagesAvailable, onReady callback of a ServerStream's listener), the Status.UNKNOWN returned to the client will have Application error processing RPC description. Previously the description was empty. This is helpful to differentiate between server errors originated in user application, gRPC library, or even those injected by a proxy. (#​10643)
  • xds: Log ORCA UNIMPLEMENTED error to subchannel logger. This removes them from the normal application logs, reducing log spam
Improvements
  • Change the underlying implementations of RingHash, RoundRobin, WeightedRoundRobin and LeastRequest load balancers to utilize the pick first load balancer rather than directly manage subchannels. This should only be noticeable if it introduced a bug
  • core: Avoid flushing headers when the server returns a single response (#​9314). This is a performance optimization to reduce the number of packets for non-streaming responses
  • util: Make grpc-core an implementation dependency. This will prevent the io.grpc.internal classes in grpc-core from being visible during compilation when depending on just grpc-util
  • netty: Implement Http2Headers.isEmpty(). This fixes compatibility with Netty 4.1.101.Final.
  • netty: Add NettyServerBuilder.maxRstFramesPerWindow(). This can be used to limit impact of Rapid Reset
  • netty: Disable huffman coding in headers (#​10563). Huffman coding provides modest compression for relatively high CPU usage, especially within a data center. Rely just on the HPACK static and dynamic tables for compression, for higher performance. This only impacts header values 512 bytes or longer, as Netty already disabled Huffman for smaller values
  • alts: Improve handshake failure error message by propagating original exception (#​10644)
Bug Fixes
  • util: Remove shutdown subchannels from OD tracking (#​10683). This could have caused a memory leak on a long-lived channel. But we don’t think it could be triggered with our built-in load balancing policies.
Dependencies
  • Bump Netty to 4.1.100.Final
Acknowledgements

@​anthonyjpratti
@​fedorka
@​jpd236
@​mateusazis
@​pkoenig10
@​yannickepstein
@​amirhadadi


Configuration

📅 Schedule: Branch creation - "after 10pm" in timezone Europe/Prague, Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot added the type: dependency-upgrade Upgrade a dependency label Dec 10, 2023
@renovate renovate bot changed the title fix(deps): update managed.grpc to v1.60.0 fix(deps): update managed.grpc Dec 21, 2023
@renovate renovate bot changed the title fix(deps): update managed.grpc fix(deps): update managed.grpc to v1.60.1 Dec 21, 2023
@renovate renovate bot changed the title fix(deps): update managed.grpc to v1.60.1 fix(deps): update managed.grpc to v1.61.0 Jan 12, 2024
Copy link
Contributor Author

renovate bot commented Jan 15, 2024

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

Warning: custom changes will be lost.

In 1.61.x it's changed to runtime, so it's not getting imported in to our projects
@timyates
Copy link
Contributor

So, it looks like grpc-util in 1.59.1 had a compile dependency on grpc-core

https://central.sonatype.com/artifact/io.grpc/grpc-util/1.59.1

In 1.61.0, this is a runtime dependency

https://central.sonatype.com/artifact/io.grpc/grpc-util/1.61.0

So we had failing tests...

I've pulled it in as an API dependency here... I am not sure if this is too much, but in my head core will always be required...

Pinging @jeremyg484 and @sdelamo for a review

Copy link

sonarcloud bot commented Jan 15, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@renovate renovate bot changed the title fix(deps): update managed.grpc to v1.61.0 fix(deps): update managed.grpc to v1.61.0 - abandoned Jan 16, 2024
Copy link
Contributor Author

renovate bot commented Jan 16, 2024

Autoclosing Skipped

This PR has been flagged for autoclosing. However, it is being skipped due to the branch being already modified. Please close/delete it manually or report a bug if you think this is in error.

@sdelamo sdelamo merged commit e5673d6 into master Jan 18, 2024
13 checks passed
@sdelamo sdelamo deleted the renovate/managed.grpc branch January 18, 2024 10:25
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: dependency-upgrade Upgrade a dependency
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants