Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix java 21 #788

Merged
merged 6 commits into from
Oct 20, 2023
Merged

Fix java 21 #788

merged 6 commits into from
Oct 20, 2023

Conversation

wetted
Copy link
Contributor

@wetted wetted commented Oct 19, 2023

Supersedes #771 to stop micronaut-build force pushing it all the time

@wetted wetted self-assigned this Oct 19, 2023
@wetted wetted requested a review from timyates October 19, 2023 19:40
@wetted
Copy link
Contributor Author

wetted commented Oct 19, 2023

This build does not like the toolchain configuration. I've used this on numerous modules already. Not sure why it's a problem here:

kotlin {
    jvmToolchain {
        languageVersion.set(JavaLanguageVersion.of(17))
    }
}
   > A problem occurred configuring project ':test-suite-kotlin'.
      > A problem occurred evaluating project ':test-suite-kotlin'.
         > The value for property 'languageVersion' is final and cannot be changed any further.

Maybe another plugin is setting it internally? 🤷‍♂️

We need to add some graal hints. These are already in the next minor of micronaut... But for now we'll duplicate them here
kotlin = "1.8.22"
kotlin = "1.9.10"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is only for tests so I think it's ok... But we then need some things for graal

@sonarcloud
Copy link

sonarcloud bot commented Oct 20, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@timyates
Copy link
Contributor

If this is for the 4.2.0 release, should we bump the minor version, and use the latest 4.1.x core and platform dependencies?

@wetted wetted requested a review from sdelamo October 20, 2023 14:08
@wetted wetted marked this pull request as ready for review October 20, 2023 14:08
@sdelamo sdelamo merged commit b4e5953 into master Oct 20, 2023
14 checks passed
@sdelamo sdelamo deleted the fix-java-21 branch October 20, 2023 14:10
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants