Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gRPC to M5 #706

Merged
merged 14 commits into from
May 30, 2023
Merged

gRPC to M5 #706

merged 14 commits into from
May 30, 2023

Conversation

sdelamo
Copy link
Contributor

@sdelamo sdelamo commented May 19, 2023

No description provided.

@sdelamo sdelamo added the type: dependency-upgrade Upgrade a dependency label May 19, 2023
@sdelamo sdelamo changed the title Micronaut Framework 4.0.0-M4 gRPC to M5 May 24, 2023
@timyates
Copy link
Contributor

So the failures seem to be caused by Conversion issues.

We're getting:

Internal Server Error: Cannot encode value [lat: 53.35014
lng: -6.266155
]. No possible encoders found for medata type: application/x-protobuf}]}}]

But we have a MediaTypeCodec and a TypeConverter<ByteBuf, Message>

Also, not sure why the error is being encoded as simply "Internal Server Error" with no details

I had to change:

def response = getMessage(url, Example.GeoPoint.class, ProtobufferCodec.PROTOBUFFER_ENCODED)

To

        def response = httpClient.toBlocking().exchange(
                HttpRequest.GET(url)
                        .header(ProtobufferCodec.X_PROTOBUF_MESSAGE_HEADER, Example.GeoPoint.class.name)
                        .header(HttpHeaders.ACCEPT, ProtobufferCodec.PROTOBUFFER_ENCODED),
                Argument.of(byte[].class),
                Argument.of(Map)
        )

        then:
        HttpClientException e = thrown(HttpClientException)

To work out what the underlying error is 🤔

@sdelamo
Copy link
Contributor Author

sdelamo commented May 27, 2023

@yawkat you probably need a message body handler too now

@sonarcloud
Copy link

sonarcloud bot commented May 30, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@graemerocher graemerocher marked this pull request as ready for review May 30, 2023 10:36
@graemerocher graemerocher merged commit abcdcbe into master May 30, 2023
@graemerocher graemerocher deleted the mn-4.0.0-M4 branch May 30, 2023 10:38
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: dependency-upgrade Upgrade a dependency
Projects
No open projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants