Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make instanceId configurable #195

Closed
ilopmar opened this issue Aug 19, 2020 · 0 comments · Fixed by #196
Closed

Make instanceId configurable #195

ilopmar opened this issue Aug 19, 2020 · 0 comments · Fixed by #196
Assignees
Labels
status: pr submitted A pull request has been submitted for the issue type: improvement A minor improvement to an existing feature

Comments

@ilopmar
Copy link
Contributor

ilopmar commented Aug 19, 2020

This is a follow up on #33.

Make instanceId configurable so when an application uses both HTTP and gRPC with service discovery, users can define a different name for the gRPC application to register to service discovery.

@ilopmar ilopmar self-assigned this Aug 19, 2020
@ilopmar ilopmar added the type: improvement A minor improvement to an existing feature label Aug 19, 2020
@ilopmar ilopmar added the status: pr submitted A pull request has been submitted for the issue label Aug 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: pr submitted A pull request has been submitted for the issue type: improvement A minor improvement to an existing feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant