Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove snapshot repos #716

Merged
merged 1 commit into from
May 11, 2023
Merged

Remove snapshot repos #716

merged 1 commit into from
May 11, 2023

Conversation

melix
Copy link
Collaborator

@melix melix commented May 11, 2023

Now that we have milestones for everything, snapshots are no longer required. Kept as comments for the next major changes.

Now that we have milestones for everything, snapshots are no
longer required. Kept as comments for the next major changes.
@melix melix self-assigned this May 11, 2023
@sonarcloud
Copy link

sonarcloud bot commented May 11, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@melix melix requested a review from alvarosanchez May 11, 2023 10:55
Copy link
Member

@alvarosanchez alvarosanchez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm curious: can you not leverage the Groovy DSL and add a method that enables snapshot repos based on a property or something? I can't do that in XML 😅, but you can. That would be better than commenting out IMO

@melix
Copy link
Collaborator Author

melix commented May 11, 2023

It is possible, the difficulty being that it's defined in several places. The issue with the DSL is when the repo is added, though.

@melix melix merged commit 73bc6a5 into master May 11, 2023
@melix melix deleted the cc/remove-snapshot-repo branch May 11, 2023 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants