Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

graalvm native-image docker replace ol7 with ol8 #714

Merged
merged 1 commit into from
May 10, 2023
Merged

Conversation

sdelamo
Copy link
Contributor

@sdelamo sdelamo commented May 10, 2023

Should we use ol7 instead of ol8 ? see:
micronaut-projects/micronaut-starter#1807

@melix
Copy link
Collaborator

melix commented May 10, 2023

mmm, look at commit 23a44a4, we reverted to ol7 precisely because of zip corruption...

@sonarcloud
Copy link

sonarcloud bot commented May 10, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@graemerocher
Copy link
Contributor

looks like it is fixed in the newer images

@melix melix merged commit d04d6c4 into master May 10, 2023
@melix melix deleted the ol8-instead-of-ol7 branch May 10, 2023 17:25
@alvarosanchez
Copy link
Member

@alvarosanchez Should we also move to ol8 in the Maven plugin?

Absolutely. It really bothers me that we still don't have a central place to change this, and we always have to play catching up games to stay in sync

@timyates
Copy link
Contributor

Raised a PR to default to ol8 micronaut-projects/micronaut-maven-plugin#723

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants