Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump minimal requirements to Java 17 #532

Merged
merged 1 commit into from
Sep 12, 2022
Merged

Bump minimal requirements to Java 17 #532

merged 1 commit into from
Sep 12, 2022

Conversation

melix
Copy link
Collaborator

@melix melix commented Sep 9, 2022

This commit upgrades the plugin to build with Java 17, but also require everything to use Java 17 minimally: this is preparation work for supporting Micronaut 4 which will raise the minimal JDK version to 17.

This doesn't upgrade transitive plugins like the Docker plugin yet.

@melix melix added type: breaking Introduces a breaking change type: improvement A minor improvement to an existing feature labels Sep 9, 2022
@melix melix added this to the 4.0.0 milestone Sep 9, 2022
@melix melix self-assigned this Sep 9, 2022
This commit upgrades the plugin to build with Java 17, but also
require everything to use Java 17 minimally: this is preparation
work for supporting Micronaut 4 which will raise the minimal JDK
version to 17.

This doesn't upgrade transitive plugins like the Docker plugin
yet.
@sonarcloud
Copy link

sonarcloud bot commented Sep 9, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

33.3% 33.3% Coverage
0.0% 0.0% Duplication

@melix melix requested a review from sdelamo September 9, 2022 12:36
@melix
Copy link
Collaborator Author

melix commented Sep 9, 2022

I'm not sure what defines the build(11) and build(8) workflows as mandatory, obviously this PR removes them.

@alvarosanchez
Copy link
Member

Isn't it too early for this change? If you plan to make future releases from a 3.5.x maintenance branch, be aware that we mostly release from master. Doing a release from a different branch may or may not work :)

I'm not sure what defines the build(11) and build(8) workflows as mandatory, obviously this PR removes them.

That is defined here: https://github.com/micronaut-projects/management/blob/master/repositories.tf#L112

src/docs/asciidoc/index.adoc Show resolved Hide resolved
src/docs/asciidoc/index.adoc Show resolved Hide resolved
src/docs/asciidoc/index.adoc Show resolved Hide resolved
@melix
Copy link
Collaborator Author

melix commented Sep 12, 2022

Isn't it too early for this change? If you plan to make future releases from a 3.5.x maintenance branch, be aware that we mostly release from master. Doing a release from a different branch may or may not work :)

Yes this is intentional, so that we have master ready for Micronaut 4.0, while we have a 3.6.x maintenance branch (there will likely be a 3.6.0 release for the CrAC feature). I have already done some releases from other branches and they worked so 🤞

@melix
Copy link
Collaborator Author

melix commented Sep 12, 2022

That is defined here: https://github.com/micronaut-projects/management/blob/master/repositories.tf#L112

I guess we can merge as is for now, this is going to be changed globally for Micronaut 4.

@melix melix merged commit 52b82c3 into master Sep 12, 2022
@melix melix deleted the cc/require-java17 branch September 12, 2022 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: breaking Introduces a breaking change type: improvement A minor improvement to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants