Fix test-resources directory not created when running clean build #529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alvarosanchez
approved these changes
Sep 2, 2022
|
Kudos, SonarCloud Quality Gate passed! |
timyates
pushed a commit
that referenced
this pull request
Sep 5, 2022
melix
added a commit
that referenced
this pull request
Sep 14, 2022
* Add a plugin to build CRaC enhanced docker images
Currently only supports APPLICATION.
This plugin adds several tasks to the CRaC group.
The flow is:
1. Copy or create scripts required for checkpointing to build/docker/main/checkpoint
2. Create a Dockerfile (build/docker/main/Dockerfile.CRaCCheckpoint) for checkpointing image
- This dockerfile installs the CRaC JDK
- runs the app, then triggers a checkpoint
- checkpoint files are written to build/docker/main/cr by the container via a volume
3. Runs this dockerfile in a container
4. Awaits the completion of this container (checks for failure in the logs)
5. Creates a Dockerfile for running the checkpointed app
- This dockerfile copies the CRaC JDK from the Checkpoint image to prevent another download
- Copies the checkpoints from build/docker/main/cr into the expected place
6. Builds an image from this dockerfile
Currently, this is only known to work on an Ubuntu 18 host, or OSX x86 machines
* javadoc: replace test resources with CRaC
* Move cr out of layers
* Make dependency API
* Add a test for dockerBuildCrac
* Use regular file property
* Use regular file property for warmup script too
* Fixes
* Test verification
* Fix checkpoint file permissions
* Smell reduction
* Add comments to Dockerfile
* Fix file var
* Fix successful test
* Fix readiness check
* Reuse existing code where appropriate
Also best practices for apt-get
* fix dockerfile
* Don't use Optional for a field, and remove unused var
* Don't apply base plugin
* Allow passing JVM args from the gradle build script
* Add test for script replacement:
* Ignore on windows
* Exclude windows properly
* Allow platform customization
* Make platform optional
* Remove superfluous image name
* Make dockerfiles cacheable
* Apply BasePlugin and DockerPlugin
* Allow readiness command configuration
* Fix test...
* Check for docker plugin
* Switch plugins to match new expectation
* Test with different plugin order
* Try and appease Sonar on a Friday night
* fix(deps): update dependency com.diffplug.gradle:goomph to v3.37.2 (#522)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
* Upgrade to Micronaut Test Resources 1.1.0 (#527)
* chore(deps): update dependency gradle to v7.5.1 (#518)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
* fix(deps): update micronaut-aot to v1.1.1 (#519)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
* chore(deps): update actions/cache action to v3.0.8 (#517)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
* chore(deps): update mikepenz/action-junit-report action to v3.3.3 (#525)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
* chore(deps): update dependency io.micronaut.build.internal.quality-checks:io.micronaut.build.internal.quality-checks.gradle.plugin to v5.3.14 (#510)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
* [skip ci] Release v3.5.2
* Back to 3.5.3-SNAPSHOT
* Upgrade default GraalVM version to 22.2 (#530)
Fixes #516
* Fix test-resources directory not created when running clean build (#529)
Fixes #528
* [skip ci] Release v3.5.3
* Back to 3.5.4-SNAPSHOT
* Made tasks abstract as per review
* Fix release download format
* Add run script and allow JAVA_OPTS
* Documentation first pass
Co-authored-by: Sergio del Amo <[email protected]>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Cédric Champeau <[email protected]>
Co-authored-by: micronaut-build <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #528