Add Support for AWS Lambda Function SDK V2 #2130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdelamo
requested changes
May 31, 2024
aws-sdk-v2/src/main/java/io/micronaut/aws/sdk/v2/service/lambda/LambdaClientFactory.java
Outdated
Show resolved
Hide resolved
aws-sdk-v2/src/main/java/io/micronaut/aws/sdk/v2/service/lambda/package-info.java
Outdated
Show resolved
Hide resolved
sdelamo
requested changes
Jul 1, 2024
| import software.amazon.awssdk.services.lambda.LambdaClientBuilder; | ||
|
|
||
|
|
||
| public class LambdaClientFactory extends AwsClientFactory<LambdaClientBuilder, LambdaAsyncClientBuilder, LambdaClient, LambdaAsyncClient> { |
There was a problem hiding this comment.
it misses javadoc, @Factory and a test.
sdelamo
requested changes
Jul 1, 2024
aws-sdk-v2/src/main/java/io/micronaut/aws/sdk/v2/service/lambda/package-info.java
Outdated
Show resolved
Hide resolved
aws-sdk-v2/src/main/java/io/micronaut/aws/sdk/v2/service/lambda/package-info.java
Outdated
Show resolved
Hide resolved
…a/package-info.java
…a/package-info.java
sdelamo
requested changes
Jul 1, 2024
...client-aws-v2/src/main/java/io/micronaut/function/client/aws/AwsInvokeRequestDefinition.java
Outdated
Show resolved
Hide resolved
...client-aws-v2/src/main/java/io/micronaut/function/client/aws/AwsInvokeRequestDefinition.java
Outdated
Show resolved
Hide resolved
| import io.micronaut.function.client.FunctionDefinition; | ||
|
|
||
| /** | ||
| * Builds an {@link InvokeRequest} for each definition under {@code aws.lambda.functions}. |
There was a problem hiding this comment.
is the javadoc correct here?
function-client-aws-v2/src/main/java/io/micronaut/function/client/aws/package-info.java
Outdated
Show resolved
Hide resolved
function-client-aws-v2/src/main/java/io/micronaut/function/client/aws/package-info.java
Outdated
Show resolved
Hide resolved
…ent/aws/package-info.java
…ent/aws/package-info.java
…ent/aws/AwsInvokeRequestDefinition.java
…ent/aws/AwsInvokeRequestDefinition.java
don’t use yaml configuration
This PR moves a Java test which was not being run as it was a JUnit 4 test to `src/test/java` and transforms it into a JUnit5 test. It updates to latest Micronaut core as it was failing locally for me without this upgrade.
sdelamo
approved these changes
Jul 4, 2024
|
any ETA on this one ? |
I am going to check again next week. But there were some build failures. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2121