Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix serialization infinite recursion #2060

Merged
merged 1 commit into from
Feb 26, 2024
Merged

Fix serialization infinite recursion #2060

merged 1 commit into from
Feb 26, 2024

Conversation

dstepanov
Copy link
Contributor

Fixes #2059

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Feb 26, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

timyates
timyates approved these changes Feb 26, 2024
View reviewed changes
Copy link
Contributor

@timyates timyates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but I'm not sure why it was added 🤔

@sdelamo do you agree this was probably a mistake?

@sdelamo
Copy link
Contributor

sdelamo commented Feb 26, 2024

Approved, but I'm not sure why it was added 🤔

@sdelamo do you agree this was probably a mistake?

Yes, it seems like a mistake.

@sdelamo sdelamo merged commit 8766bc1 into master Feb 26, 2024
15 checks passed
@sdelamo sdelamo deleted the fixser branch February 26, 2024 14:13
@driverpt
Copy link
Contributor

What's the ETA of this Release?

@timyates timyates mentioned this pull request Feb 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timyates timyates timyates approved these changes

@sdelamo sdelamo Awaiting requested review from sdelamo

Assignees
No one assigned
Labels
None yet
Projects
No open projects
4.3.4 Release
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Problem JSON Infinite Recursion on Serialization
4 participants
@dstepanov @sdelamo @driverpt @timyates