Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: improve paramterstore configuration reference #2034

Merged
merged 2 commits into from
Feb 1, 2024
Merged

doc: improve paramterstore configuration reference #2034

merged 2 commits into from
Feb 1, 2024

Conversation

sdelamo
Copy link
Contributor

@sdelamo sdelamo commented Feb 1, 2024

No description provided.

@sdelamo sdelamo requested a review from timyates February 1, 2024 06:41
timyates
timyates approved these changes Feb 1, 2024
View reviewed changes
Copy link
Contributor

@timyates timyates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added some javadoc to setPrefixes too as that was missing in the configuration-properties description for that field.

I took the description from the super-class

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Feb 1, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@sdelamo sdelamo merged commit 70f6ab5 into master Feb 1, 2024
13 checks passed
@sdelamo sdelamo deleted the improve-configuration-reference-documentation branch February 1, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timyates timyates timyates approved these changes

Assignees
No one assigned
Labels
type: docs
Projects
No open projects
4.3.0 Release
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sdelamo @timyates