fix: CustomPojoSerializer only for Serde

[sdelamo]

Close #1914

This PR remove the CustomPojoSerializer when using JacksonDatabind.

Jackson’s ObjectMapper creation requires customization which I don’t think it make sense to replicate in our CustomPojoSerializer.

https://github.com/aws/aws-lambda-java-libs/blob/main/aws-lambda-java-serialization/src/main/java/com/amazonaws/services/lambda/runtime/serialization/factories/JacksonFactory.java#L57-L93

[timyates]

1 question and a suggestion for the docs wording...

I pushed a commit that cleaned up unused imports, added a private constructor to CustomPojoSerializerUtils and used generics in CustomPojoSerializerUtils.serializeFromJson -- which I think is correct

The reproducer for this issue passes locally, so I assume this only fails on AWS? Have you tried the reproducer on AWS with both Serde and Jackson?

[sonarcloud]

SonarCloud Quality Gate failed.   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

0.0% Coverage
0.0% Duplication

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

[sdelamo]

The reproducer for this issue passes locally, so I assume this only fails on AWS? Have you tried the reproducer on AWS with both Serde and Jackson?

It did not passed locally. It failed.

I moved src/main/resources/META-INF/services/com.amazonaws.services.lambda.runtime.CustomPojoSerializer to
aws-lambda-events-serde/src/main/resources/META-INF/services/com.amazonaws.services.lambda.runtime.CustomPojoSerializer so that for Jackson-databind it is not loaded.

I instead load in our tests the ObjectMapper with LambdaEventSerializers.serializerForwhich is the way internally AWS does it if you don't use have a CustomPojoSerializer.