Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce mechanism to avoid loading default config files #1886

Conversation

guillermocalvo
Copy link

No description provided.

@guillermocalvo guillermocalvo added the type: improvement A minor improvement to an existing feature label Sep 19, 2023
@sonarcloud
Copy link

sonarcloud bot commented Sep 19, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@sdelamo
Copy link
Contributor

sdelamo commented Sep 21, 2023

@guillermocalvo check the Azure module. we probably have the same situation.

@guillermocalvo
Copy link
Author

guillermocalvo commented Sep 21, 2023

check the Azure module. we probably have the same situation.

@sdelamo Azure config client doesn't try to fetch default config files. Instead, it iterates over secretClient.listSecrets().

So I don't think a new config property default-config-enabled would make sense in that case.

@sdelamo
Copy link
Contributor

sdelamo commented Feb 1, 2024

@guillermocalvo Sorry but I am going to close this PR. I have been thinking more about this and I think with the already existing options users can reduce the number of searched prefixes. see: #2033

@sdelamo sdelamo closed this Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: improvement A minor improvement to an existing feature
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants