Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added reflection metadata to aws-cloudwatch-logging module #1860

Merged
merged 3 commits into from
Aug 31, 2023
Merged

Added reflection metadata to aws-cloudwatch-logging module #1860

merged 3 commits into from
Aug 31, 2023

Conversation

msupic
Copy link
Contributor

@msupic msupic commented Aug 31, 2023

No description provided.

sdelamo
sdelamo approved these changes Aug 31, 2023
View reviewed changes
Copy link
Contributor

@sdelamo sdelamo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this reflection configuration not be in the GraalVM Metadata repository?

@sonarcloud
Copy link

sonarcloud bot commented Aug 31, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@msupic
Copy link
Contributor Author

msupic commented Aug 31, 2023

@sdelamo - CloudWatchLoggingAppender and CloudWatchJsonFormatter metadata should be in micronaut-aws-cloudwatch-logging since those are micronaut classes. LayoutWrappingEncoder, JsonLayoutBase and JsonLayout metadata are temporarily placed here until the following PRs get approved and new version of metadata repository get released:

https://github.com/oracle/graalvm-reachability-metadata/pull/372
https://github.com/oracle/graalvm-reachability-metadata/pull/378

Since entire process of adding metadata to the shared repository is extremely slow (can take a few months until PRs are approved, a new release of metadata repository created, a new release of NBT plugin created and then that NBT release used in micronaut gradle and maven plugins), I temporarily added those metadata to micronaut modules. Those metadata will be removed when entire above mentioned process gets completed.

@msupic msupic merged commit db708fe into master Aug 31, 2023
9 of 10 checks passed
@msupic msupic deleted the logging-metadata branch August 31, 2023 09:11
@sdelamo
Copy link
Contributor

sdelamo commented Aug 31, 2023

how are we tracking the things we have to remove when they are in the Metadata repository? Are you creating issues so that we don't forget?

@msupic
Copy link
Contributor Author

msupic commented Aug 31, 2023

It doesn't happen often that I add new metadata which need to be removed later when a new version of NBT plugin is released so I am tracking those cases locally. If you prefer, I can create new issues for those cases?

sdelamo pushed a commit that referenced this pull request Sep 1, 2023
@msupic @sdelamo
Added reflection metadata to aws-cloudwatch-logging module (#1860)
b63216d 
* Added reflection metadata to aws-cloudwatch-logging module

* Added reflection metadata to aws-cloudwatch-logging module

* Added reflection metadata to aws-cloudwatch-logging module
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdelamo sdelamo sdelamo approved these changes

Assignees
No one assigned
Labels
relates-to: graal
Projects
No open projects
4.1.0 Release
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@msupic @sdelamo