Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Application Load Balancer Handler #1765

Merged
merged 14 commits into from
Jun 12, 2023
Merged

Adds Application Load Balancer Handler #1765

merged 14 commits into from
Jun 12, 2023

Conversation

sdelamo
Copy link
Contributor

@sdelamo sdelamo commented Jun 12, 2023

see: #1733

# Conflicts:
#	function-aws-api-proxy/src/main/java/io/micronaut/function/aws/proxy/ApiGatewayServletRequest.java
@sdelamo sdelamo added the type: enhancement New feature or request label Jun 12, 2023
@sdelamo sdelamo requested a review from timyates June 12, 2023 10:46
Copy link
Contributor

@timyates timyates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have we tested this to make sure it fixes the issue they describe in their verification?

@sonarcloud
Copy link

sonarcloud bot commented Jun 12, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

0.0% 0.0% Coverage
5.4% 5.4% Duplication

@sdelamo sdelamo merged commit 723328f into master Jun 12, 2023
@sdelamo sdelamo deleted the alb branch June 12, 2023 13:38
@sdelamo
Copy link
Contributor Author

sdelamo commented Jun 12, 2023

Have we tested this to make sure it fixes the issue they describe in their verification?

No, I am going to do that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement New feature or request
Projects
No open projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants