Add application/zip as a binary type and allow configuration #1754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously when we used serverless, we added application/zip to the list of binary types. This was lost when we moved away from serverless, and was caught by a test in starter micronaut-projects/micronaut-starter#1853 This PR changes from a static set of binary types to a singleton bean that allows types to be added to the set. It also adds application/zip as a binary type by default.
|
SonarCloud Quality Gate failed. |
sdelamo
approved these changes
Jun 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously when we used serverless, we added application/zip to the list of binary types.
This was lost when we moved away from serverless, and was caught by a test in starter
micronaut-projects/micronaut-starter#1853
This PR changes from a static set of binary types to a singleton bean that allows types to be added to the set. It also adds application/zip as a binary type by default.