-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate Lambda to use servlet core #1650
Conversation
timyates
commented
Mar 17, 2023
•
edited by sdelamo
Loading
edited by sdelamo
- It updates to the latest milestones
- It deletes CDK module (it will be moved to starter).
- It moves away from AWS Serverless Java Container. It use servlet core.
- It supports both payload versions v1 and v2.
- Handlers use standard AWS Lambda Java Events POJOs.
- TCK passes almost complety.
- There is some work still to do in the the proxy-test. Several tests don't pass.
Flux test currently fails with This also doesn't currently support binary payloads in the body, we will need to mime encode them |
do you have the |
Added |
|
||
private ServletHttpHandler<APIGatewayProxyRequestEvent, APIGatewayProxyResponseEvent> initializeHandler() { | ||
ApiGatewayProxyEventHandler apiGatewayProxyEventHandler = new ApiGatewayProxyEventHandler(applicationContext); | ||
Runtime.getRuntime().addShutdownHook( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion: Add Base class AWSLambdaHttpRequestFunction
w/ method onShutdown()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, just go through the code and annotate more types and packages with @Internal
since I think we should keep the public API surface area here small
function-aws-api-proxy/src/main/java/io/micronaut/function/aws/proxy/AwsCookies.java
Outdated
Show resolved
Hide resolved
function-aws-api-proxy/src/main/java/io/micronaut/function/aws/proxy/MultiValue.java
Outdated
Show resolved
Hide resolved
...api-proxy/src/main/java/io/micronaut/function/aws/proxy/MultiValueMutableHttpParameters.java
Outdated
Show resolved
Hide resolved
… make it package private
add @internal make the class final
SonarCloud Quality Gate failed. |