Skip to content

Return null immediately when sla is null in convertSla() #746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 23, 2018
Merged

Return null immediately when sla is null in convertSla() #746

merged 1 commit into from
Jul 23, 2018

Conversation

@izeye
Copy link
Contributor

@izeye izeye commented Jul 20, 2018

This PR changes to return null immediately when sla is null in PropertiesMeterFilter.convertSla() as passing through the stream pipeline isn't necessary.

@jkschneider jkschneider added this to the 1.0.7 milestone Jul 23, 2018
@jkschneider jkschneider merged commit 3dd6eb0 into micrometer-metrics:1.0.x Jul 23, 2018
@izeye izeye deleted the convert-sla branch July 23, 2018 23:24
izeye added a commit to izeye/spring-boot that referenced this pull request Aug 2, 2018
@izeye
Return null immediately when sla is null in convertSla()
19298a7 
See micrometer-metrics/micrometer#746
@izeye izeye mentioned this pull request Aug 2, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.0.7

Development

Successfully merging this pull request may close these issues.

2 participants

@izeye @jkschneider