Skip to content

Fix Jetty metrics instrumentation #633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 4, 2018
Merged

Fix Jetty metrics instrumentation #633

merged 1 commit into from
Jun 4, 2018

Conversation

@mweirauch
Copy link
Contributor

The factory is being asked to create a server before our configuration
has a chance to kick in.

Relates to #593.

@mweirauch
Fix Jetty metrics instrumentation
b9c6781 
The factory is being asked to create a server before our configuration
has a chance to kick in.

Relates to #593.
@mweirauch mweirauch added this to the 1.1.0 milestone May 31, 2018
@jkschneider
Copy link
Contributor

Thanks @mweirauch!

@jkschneider jkschneider merged commit b5bfd38 into master Jun 4, 2018
mweirauch added a commit that referenced this pull request Jun 18, 2018
@mweirauch
Fix early MeterRegistry creation on Jetty metrics auto configuration
b5724e6 
This regression was introduced with #633. Looking up the MeterRegistry
within the JettyMetricsPostProcessor fixes this. (One effect was
common tags not being applied.)

This PR is based on #662 which should be merged before.
@mweirauch mweirauch mentioned this pull request Jun 18, 2018
Merged
mweirauch added a commit that referenced this pull request Jun 21, 2018
@mweirauch
Fix early MeterRegistry creation on Jetty metrics auto configuration
2729bc5 
This regression was introduced with #633. Looking up the MeterRegistry
within the JettyMetricsPostProcessor fixes this. (One effect was
common tags not being applied.)

This PR is based on #662 which should be merged before.
mweirauch added a commit that referenced this pull request Jun 21, 2018
@mweirauch
Fix early MeterRegistry creation on Jetty metrics auto configuration (#…
796c33b 
…665)

This regression was introduced with #633. Looking up the MeterRegistry
within the JettyMetricsPostProcessor fixes this. (One effect was
common tags not being applied.)
@mweirauch mweirauch deleted the fix-jetty-metrics-instrumentation branch June 25, 2018 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.1.0-rc.1

Development

Successfully merging this pull request may close these issues.

3 participants

@mweirauch @jkschneider