Allow customizing PrometheusProperties via PrometheusConfig #4921
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonatan-ivanov
commented
Apr 4, 2024
| @Nullable | ||
| default Properties prometheusProperties() { | ||
| Properties properties = new Properties(); | ||
| properties.setProperty("io.prometheus.exporter.exemplarsOnAllMetricTypes", "true"); |
Member
Author
There was a problem hiding this comment.
We enable exemplars by default.
If somebody overrides this method, they can do this to reuse the Micrometer defaults but also define their own (see the tests):
@Override
public Properties prometheusProperties() {
Properties properties = new Properties();
properties.putAll(PrometheusConfig.super.prometheusProperties());
properties.setProperty("io.prometheus.exemplars.sampleIntervalMilliseconds", "42");
return properties;
}
jonatan-ivanov
removed
enhancement
shakuzen
approved these changes
Apr 5, 2024
Member
shakuzen
left a comment
shakuzen
left a comment
There was a problem hiding this comment.
Looks good. I left some feedback we can consider in a follow-up if we want to pursue it.
...eter-registry-prometheus/src/main/java/io/micrometer/prometheusmetrics/PrometheusConfig.java
Show resolved
Hide resolved
shakuzen
changed the title
This was referenced Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.